Added null Protection for getAcademy
#6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addressed a potential `null` academy issue in `EducationController` by adding a validation check and returning early if the academy is not found. - Annotated `getAcademy` method with `@Nullable` to clearly indicate possible null return values. - Refactored and improved code formatting consistency across multiple files: - Simplified logical conditions and improved readability. - Adjusted indentation, line breaks, and spacing for better clarity.
IllianiBird
added
Bug
Severity: Medium
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6532 +/- ##
============================================
- Coverage 11.28% 11.27% -0.01%
+ Complexity 6321 6318 -3
============================================
Files 1080 1080
Lines 137543 137563 +20
Branches 21300 21301 +1
============================================
- Hits 15517 15511 -6
- Misses 120473 120497 +24
- Partials 1553 1555 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjhancock
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullacademy issue inEducationControllerby adding a validation check and returning early if the academy is not found.getAcademymethod with@Nullableto clearly indicate possible null return values.Dev Notes
Predominately this fixes an issue with personnel the player has manually assigned to the STUDENT status.