Fixes Compatibility for AC Ammo in MHQ #6542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6542 +/- ##
=========================================
Coverage 11.27% 11.28%
- Complexity 6316 6323 +7
=========================================
Files 1080 1080
Lines 137527 137528 +1
Branches 21294 21295 +1
=========================================
+ Hits 15509 15516 +7
Misses 120463 120463
+ Partials 1555 1549 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sleet01
reviewed
Apr 3, 2025
| getType().isCompatibleWith(((AmmoBin) part).getType()) && | ||
| (((AmmoBin) part).getFullShots() == getFullShots()); | ||
| ((getType().isCompatibleWith(((AmmoBin) part).getType())) || | ||
| (getType().equals(((AmmoBin) part).getType()))) && |
There was a problem hiding this comment.
Sorry, just wanted to echo Illiani's comment. That must have been super-annoying to track down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MekHQ,
AmmoBin::isSamePartTypedoes not properly recognize AC ammo as being the same part type. Two AC/5 ammo bins, for example. This led to any refit in MHQ for a unit that had AC ammo would show as needing changed in the refit even if nothing was changed.In the below screenshots, nothing was changed for this unit. I right clicked the unit in the Hangar and selected customize > customize in mek lab. I made no changes to the unit before taking the screenshots.
Before Fix:
After Fix:
