Refactored Edge Handling to Use Adjusted Edge Values #6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced calls to `getEdge()` with `getAdjustedEdge()` to account for the "unlucky" trait in edge calculations. - Updated `PersonViewPanel` to display adjusted edge values in the GUI. - Modified the `resetCurrentEdge` method to reset based on the adjusted edge value. - Incorporated safeguarded adjustments (e.g., ensuring edge values are non-negative) in calculations. - Improved method documentation for `getEdge()` and `getAdjustedEdge()` to clarify usage and behavior.
…nners to account for prior Edge usage.
IllianiCBT
added
Bug
GUI
Severity: Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6573 +/- ##
==========================================
Coverage 11.57% 11.58%
+ Complexity 6401 6400 -1
==========================================
Files 1085 1085
Lines 139499 139605 +106
Branches 21514 21532 +18
==========================================
+ Hits 16149 16172 +23
- Misses 121776 121863 +87
+ Partials 1574 1570 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getEdge()withgetAdjustedEdge()to account for the "unlucky" trait in edge calculations.PersonViewPanelto display adjusted edge values in the GUI.resetCurrentEdgemethod to reset based on the adjusted edge value.getEdge()andgetAdjustedEdge()to clarify usage and behavior.Dev Notes
When I first implemented Unlucky I modified the
getEdgemethod. That was a poor call, as it meant we could no longer view Edge score without incorporating Unlucky. So I went back and moved Unlucky out ofgetEdgeand createdgetAdjustedEdgewhich does include Unlucky.I then went through and updated relevant calls to
getEdgeto use the newgetAdjustedEdgemethod, where appropriate.Finally, I fixed a bug with
Unitthat was causing any Edge used to be disregarded when determining the Edge available to a crew. Basically, we were always assuming those characters had their full allowance of Edge, when that might not be the case. Such as when there are rapid successive deployments, or if a member of the crew is also a Technician who spent some of their Edge on repair tasks.