Updated Aging Effects to Include Clan Reputation Modifiers & Glass Jaw Gain #6575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced direct access to `Person.getReputation()` with `getAdjustedReputation()` for better handling of age, clan affiliation, and campaign options. - Introduced `applyAgingSPA()` and `getReputationAgeModifier()` for age-related effects and reputation adjustments. - Simplified and optimized existing logic for skill and reputation calculations. - Introduced `isClanCampaign()` to determine clan-based campaign properties. - Fixed formatting inconsistencies in Resupply class documentation.
- Replaced direct access to `Person.getReputation()` with `getAdjustedReputation()` for better handling of age, clan affiliation, and campaign options. - Introduced `applyAgingSPA()` and `getReputationAgeModifier()` for age-related effects and reputation adjustments. - Simplified and optimized existing logic for skill and reputation calculations. - Introduced `isClanCampaign()` to determine clan-based campaign properties. - Fixed formatting inconsistencies in Resupply class documentation.
IllianiCBT
added
Bug
Refactoring
Severity: Low
…putation(boolean, boolean, LocalDate, int)` instead of the outdated one.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6575 +/- ##
==========================================
Coverage 11.57% 11.58%
Complexity 6401 6401
==========================================
Files 1085 1085
Lines 139499 139656 +157
Branches 21514 21537 +23
==========================================
+ Hits 16149 16174 +25
- Misses 121776 121909 +133
+ Partials 1574 1573 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Notes
This PR expands our aging implementation to inflict Glass Jaw on characters whenever they hit certain milestones. As per RAW this SPA gain is inflicted every valid milestone. So while the character can mitigate it with repeated purchases of the Toughness SPA, that gets expensive quick.
I also went and implemented Reputation penalties for non-blood named characters in Clan Campaigns once they hit specific Milestones. This required refactoring how Reputation is fetched, which also exposed a couple of minor bugs which I cleaned up as I went.