Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Infinite Loop in getAvailableForceIDs (Sentry) #6580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IllianiCBT
Copy link
Collaborator

@IllianiCBT IllianiCBT commented Apr 7, 2025

  • Updated the condition in StratconRulesManager to include a check for the bypassRoleRestrictions flag when determining if suitable forces are empty.
  • Prevented unintended infinite fallback to getAvailableForceIDs in the event no suitable forces exist, even with restrictions relaxed.
  • Added detailed logging to indicate when no suitable combat teams are found. So we don't have to guess what happened if we get player reports that no scenarios are spawning.

Fix Sentry Report

- Updated the condition in `StratconRulesManager` to include a check for the `bypassRoleRestrictions` flag when determining if suitable forces are empty.
- Prevented unintended infinite fallback to `getAvailableForceIDs` in the event no suitable forces exist, even with restrictions relaxed.
- Added detailed logging to indicate when no suitable combat teams are found.
@IllianiCBT IllianiCBT added Bug StratCon Bugs relating strictly to StratCon Severity: Medium Issues described as medium severity as per the new issue form labels Apr 7, 2025
@IllianiCBT IllianiCBT self-assigned this Apr 7, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.43%. Comparing base (f44952c) to head (e99e832).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6580   +/-   ##
=========================================
  Coverage     11.43%   11.43%           
- Complexity     6451     6453    +2     
=========================================
  Files          1087     1087           
  Lines        139447   139451    +4     
  Branches      21560    21561    +1     
=========================================
+ Hits          15944    15950    +6     
+ Misses       121908   121905    -3     
- Partials       1595     1596    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IllianiCBT IllianiCBT changed the title Fixed Infinite Loop in getAvailableForceIDs Fixed Infinite Loop in getAvailableForceIDs (Sentry) Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Severity: Medium Issues described as medium severity as per the new issue form StratCon Bugs relating strictly to StratCon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant