Ensured StratCon Campaigns Always Generate At Least One Track (Sentry) #6581
+103
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored logic to extract reusable helper methods `getScenarioOdds` and `getDeploymentTime`, improving code clarity and maintainability. - Introduced fallback mechanism to guarantee a minimum of one track in StratCon Areas of Operation, preventing cases where zero tracks are generated. - Added `getTrackCount` method in `StratconCampaignState` to replace direct use of `getTracks().size()`. - Corrected potential division by zero errors when distributing track objects by ensuring a valid track count.
IllianiCBT
added
Bug
StratCon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6581 +/- ##
=========================================
Coverage 11.43% 11.43%
- Complexity 6451 6455 +4
=========================================
Files 1087 1087
Lines 139447 139454 +7
Branches 21560 21561 +1
=========================================
+ Hits 15944 15951 +7
+ Misses 121908 121906 -2
- Partials 1595 1597 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IllianiCBT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getScenarioOddsandgetDeploymentTime, improving code clarity and maintainability.getTrackCountmethod inStratconCampaignStateto replace direct use ofgetTracks().size().Fix Sentry Report