Fix #6546: Fixed Display of Misc Award Images; Upgraded Award Image Scaling #6583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed misc image count to return misc images and not medals. - Added logging to warn if image files (ribbons, medals, misc) are missing. - Adjusted the maximum number of ribbon awards per row from 4 to 3 for better display with the new scaling tech. - Introduced `scaleImage` method in `ImageUtilities`. This is essentially a duplicate of `scaleImageIcon`, with reused components separated into a shared method. - Replaced award image scaling in `PersonViewPanel` with the new `scaleImage` method from `ImageUtilities`.
IllianiCBT
added
Bug
Awards
GUI
Severity: Low
IllianiCBT
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6583 +/- ##
=========================================
Coverage 11.43% 11.43%
- Complexity 6451 6455 +4
=========================================
Files 1087 1087
Lines 139447 139449 +2
Branches 21560 21557 -3
=========================================
+ Hits 15944 15946 +2
- Misses 121908 121910 +2
+ Partials 1595 1593 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scaleImagemethod inImageUtilities. This is essentially a duplicate ofscaleImageIcon, with reused components separated into a shared method.PersonViewPanelwith the newscaleImagemethod fromImageUtilities.Fix #6546
Dev Notes
Users may notice some images appearing different once this has been merged, that will be because we are now respecting the image's aspect ratio, rather than using fixed values.