Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6544: Restored Ability to Salvage Turrets #6584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IllianiCBT
Copy link
Collaborator

  • Removed code that prevented players from salvaging turrets, specifically gun emplacements.

Fix #6544

Dev Notes

This was leftover code from 50.03 when we first prevented the player from acquiring gun emplacements, prior to us implementing the Unsupported Unit class.

- Removed code that prevented players from salvaging turrets, specifically gun emplacements.
@IllianiCBT IllianiCBT added Bug Scenario Resolution Severity: Low Issues described as low severity as per the new issue form labels Apr 7, 2025
@IllianiCBT IllianiCBT self-assigned this Apr 7, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.43%. Comparing base (f44952c) to head (3e9cd2a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6584   +/-   ##
=========================================
  Coverage     11.43%   11.43%           
- Complexity     6451     6453    +2     
=========================================
  Files          1087     1087           
  Lines        139447   139444    -3     
  Branches      21560    21559    -1     
=========================================
+ Hits          15944    15952    +8     
+ Misses       121908   121898   -10     
+ Partials       1595     1594    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Scenario Resolution Severity: Low Issues described as low severity as per the new issue form
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]Destroyed turrets not showing up as salvage after base attack scenarios
1 participant