Skip to content

fix: improve multichainTokenBalances and multichainAssetsRates controller state updates #5761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix: improve multichainTokenBalances and multichainAssetsRates controller state updates #5761

wants to merge 22 commits into from

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented May 5, 2025 •
edited
Loading

Explanation

Both MultichainTokenBalancesController and MultichainAssetsRatesController used to subscribe to MultichainAssetsController:stateChange which was triggering state updates for all existing accounts on every update.

Instead; MultichainAssetsController will now publish new event MultichainAssetsController:newAccountAssets that is published whenever new assets are added for specific accounts, and controllers can subscribe to that instead.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-377dcaaa",
  "@metamask-previews/address-book-controller": "6.0.3-preview-377dcaaa",
  "@metamask-previews/announcement-controller": "7.0.3-preview-377dcaaa",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-377dcaaa",
  "@metamask-previews/approval-controller": "7.1.3-preview-377dcaaa",
  "@metamask-previews/assets-controllers": "60.0.0-preview-377dcaaa",
  "@metamask-previews/base-controller": "8.0.1-preview-377dcaaa",
  "@metamask-previews/bridge-controller": "20.0.0-preview-377dcaaa",
  "@metamask-previews/bridge-status-controller": "17.0.0-preview-377dcaaa",
  "@metamask-previews/build-utils": "3.0.3-preview-377dcaaa",
  "@metamask-previews/chain-agnostic-permission": "0.5.0-preview-377dcaaa",
  "@metamask-previews/composable-controller": "11.0.0-preview-377dcaaa",
  "@metamask-previews/controller-utils": "11.7.0-preview-377dcaaa",
  "@metamask-previews/delegation-controller": "0.1.0-preview-377dcaaa",
  "@metamask-previews/earn-controller": "0.12.0-preview-377dcaaa",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-377dcaaa",
  "@metamask-previews/ens-controller": "16.0.0-preview-377dcaaa",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-377dcaaa",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-377dcaaa",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-377dcaaa",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-377dcaaa",
  "@metamask-previews/keyring-controller": "21.0.5-preview-377dcaaa",
  "@metamask-previews/logging-controller": "6.0.4-preview-377dcaaa",
  "@metamask-previews/message-manager": "12.0.1-preview-377dcaaa",
  "@metamask-previews/multichain": "4.0.0-preview-377dcaaa",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-377dcaaa",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-377dcaaa",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-377dcaaa",
  "@metamask-previews/name-controller": "8.0.3-preview-377dcaaa",
  "@metamask-previews/network-controller": "23.3.0-preview-377dcaaa",
  "@metamask-previews/notification-services-controller": "6.0.1-preview-377dcaaa",
  "@metamask-previews/permission-controller": "11.0.6-preview-377dcaaa",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-377dcaaa",
  "@metamask-previews/phishing-controller": "12.5.0-preview-377dcaaa",
  "@metamask-previews/polling-controller": "13.0.0-preview-377dcaaa",
  "@metamask-previews/preferences-controller": "17.0.0-preview-377dcaaa",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-377dcaaa",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-377dcaaa",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-377dcaaa",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-377dcaaa",
  "@metamask-previews/sample-controllers": "0.1.0-preview-377dcaaa",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-377dcaaa",
  "@metamask-previews/signature-controller": "27.1.0-preview-377dcaaa",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-377dcaaa",
  "@metamask-previews/transaction-controller": "54.4.0-preview-377dcaaa",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-377dcaaa"
}

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-13389068",
  "@metamask-previews/address-book-controller": "6.0.3-preview-13389068",
  "@metamask-previews/announcement-controller": "7.0.3-preview-13389068",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-13389068",
  "@metamask-previews/approval-controller": "7.1.3-preview-13389068",
  "@metamask-previews/assets-controllers": "60.0.0-preview-13389068",
  "@metamask-previews/base-controller": "8.0.1-preview-13389068",
  "@metamask-previews/bridge-controller": "20.0.0-preview-13389068",
  "@metamask-previews/bridge-status-controller": "17.0.0-preview-13389068",
  "@metamask-previews/build-utils": "3.0.3-preview-13389068",
  "@metamask-previews/chain-agnostic-permission": "0.5.0-preview-13389068",
  "@metamask-previews/composable-controller": "11.0.0-preview-13389068",
  "@metamask-previews/controller-utils": "11.7.0-preview-13389068",
  "@metamask-previews/delegation-controller": "0.1.0-preview-13389068",
  "@metamask-previews/earn-controller": "0.12.0-preview-13389068",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-13389068",
  "@metamask-previews/ens-controller": "16.0.0-preview-13389068",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-13389068",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-13389068",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-13389068",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-13389068",
  "@metamask-previews/keyring-controller": "21.0.5-preview-13389068",
  "@metamask-previews/logging-controller": "6.0.4-preview-13389068",
  "@metamask-previews/message-manager": "12.0.1-preview-13389068",
  "@metamask-previews/multichain": "4.0.0-preview-13389068",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-13389068",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-13389068",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-13389068",
  "@metamask-previews/name-controller": "8.0.3-preview-13389068",
  "@metamask-previews/network-controller": "23.3.0-preview-13389068",
  "@metamask-previews/notification-services-controller": "6.0.1-preview-13389068",
  "@metamask-previews/permission-controller": "11.0.6-preview-13389068",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-13389068",
  "@metamask-previews/phishing-controller": "12.5.0-preview-13389068",
  "@metamask-previews/polling-controller": "13.0.0-preview-13389068",
  "@metamask-previews/preferences-controller": "17.0.0-preview-13389068",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-13389068",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-13389068",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-13389068",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-13389068",
  "@metamask-previews/sample-controllers": "0.1.0-preview-13389068",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-13389068",
  "@metamask-previews/signature-controller": "27.1.0-preview-13389068",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-13389068",
  "@metamask-previews/transaction-controller": "54.4.0-preview-13389068",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-13389068"
}

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-664bfa2d",
  "@metamask-previews/address-book-controller": "6.0.3-preview-664bfa2d",
  "@metamask-previews/announcement-controller": "7.0.3-preview-664bfa2d",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-664bfa2d",
  "@metamask-previews/approval-controller": "7.1.3-preview-664bfa2d",
  "@metamask-previews/assets-controllers": "60.0.0-preview-664bfa2d",
  "@metamask-previews/base-controller": "8.0.1-preview-664bfa2d",
  "@metamask-previews/bridge-controller": "20.0.0-preview-664bfa2d",
  "@metamask-previews/bridge-status-controller": "17.0.0-preview-664bfa2d",
  "@metamask-previews/build-utils": "3.0.3-preview-664bfa2d",
  "@metamask-previews/chain-agnostic-permission": "0.5.0-preview-664bfa2d",
  "@metamask-previews/composable-controller": "11.0.0-preview-664bfa2d",
  "@metamask-previews/controller-utils": "11.7.0-preview-664bfa2d",
  "@metamask-previews/delegation-controller": "0.1.0-preview-664bfa2d",
  "@metamask-previews/earn-controller": "0.12.0-preview-664bfa2d",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-664bfa2d",
  "@metamask-previews/ens-controller": "16.0.0-preview-664bfa2d",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-664bfa2d",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-664bfa2d",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-664bfa2d",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-664bfa2d",
  "@metamask-previews/keyring-controller": "21.0.5-preview-664bfa2d",
  "@metamask-previews/logging-controller": "6.0.4-preview-664bfa2d",
  "@metamask-previews/message-manager": "12.0.1-preview-664bfa2d",
  "@metamask-previews/multichain": "4.0.0-preview-664bfa2d",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-664bfa2d",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-664bfa2d",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-664bfa2d",
  "@metamask-previews/name-controller": "8.0.3-preview-664bfa2d",
  "@metamask-previews/network-controller": "23.3.0-preview-664bfa2d",
  "@metamask-previews/notification-services-controller": "6.0.1-preview-664bfa2d",
  "@metamask-previews/permission-controller": "11.0.6-preview-664bfa2d",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-664bfa2d",
  "@metamask-previews/phishing-controller": "12.5.0-preview-664bfa2d",
  "@metamask-previews/polling-controller": "13.0.0-preview-664bfa2d",
  "@metamask-previews/preferences-controller": "17.0.0-preview-664bfa2d",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-664bfa2d",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-664bfa2d",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-664bfa2d",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-664bfa2d",
  "@metamask-previews/sample-controllers": "0.1.0-preview-664bfa2d",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-664bfa2d",
  "@metamask-previews/signature-controller": "27.1.0-preview-664bfa2d",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-664bfa2d",
  "@metamask-previews/transaction-controller": "54.4.0-preview-664bfa2d",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-664bfa2d"
}

@sahar-fehri sahar-fehri force-pushed the chore/perf-tokenBalances-controller branch from 664bfa2 to acb593c Compare May 5, 2025 23:41
@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-16b46c17",
  "@metamask-previews/address-book-controller": "6.0.3-preview-16b46c17",
  "@metamask-previews/announcement-controller": "7.0.3-preview-16b46c17",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-16b46c17",
  "@metamask-previews/approval-controller": "7.1.3-preview-16b46c17",
  "@metamask-previews/assets-controllers": "60.0.0-preview-16b46c17",
  "@metamask-previews/base-controller": "8.0.1-preview-16b46c17",
  "@metamask-previews/bridge-controller": "20.0.0-preview-16b46c17",
  "@metamask-previews/bridge-status-controller": "17.0.0-preview-16b46c17",
  "@metamask-previews/build-utils": "3.0.3-preview-16b46c17",
  "@metamask-previews/chain-agnostic-permission": "0.5.0-preview-16b46c17",
  "@metamask-previews/composable-controller": "11.0.0-preview-16b46c17",
  "@metamask-previews/controller-utils": "11.7.0-preview-16b46c17",
  "@metamask-previews/delegation-controller": "0.1.0-preview-16b46c17",
  "@metamask-previews/earn-controller": "0.12.0-preview-16b46c17",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-16b46c17",
  "@metamask-previews/ens-controller": "16.0.0-preview-16b46c17",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-16b46c17",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-16b46c17",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-16b46c17",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-16b46c17",
  "@metamask-previews/keyring-controller": "21.0.5-preview-16b46c17",
  "@metamask-previews/logging-controller": "6.0.4-preview-16b46c17",
  "@metamask-previews/message-manager": "12.0.1-preview-16b46c17",
  "@metamask-previews/multichain": "4.0.0-preview-16b46c17",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-16b46c17",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-16b46c17",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-16b46c17",
  "@metamask-previews/name-controller": "8.0.3-preview-16b46c17",
  "@metamask-previews/network-controller": "23.3.0-preview-16b46c17",
  "@metamask-previews/notification-services-controller": "6.0.1-preview-16b46c17",
  "@metamask-previews/permission-controller": "11.0.6-preview-16b46c17",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-16b46c17",
  "@metamask-previews/phishing-controller": "12.5.0-preview-16b46c17",
  "@metamask-previews/polling-controller": "13.0.0-preview-16b46c17",
  "@metamask-previews/preferences-controller": "17.0.0-preview-16b46c17",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-16b46c17",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-16b46c17",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-16b46c17",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-16b46c17",
  "@metamask-previews/sample-controllers": "0.1.0-preview-16b46c17",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-16b46c17",
  "@metamask-previews/signature-controller": "27.1.0-preview-16b46c17",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-16b46c17",
  "@metamask-previews/transaction-controller": "54.4.0-preview-16b46c17",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-16b46c17"
}

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-b5bc200b",
  "@metamask-previews/address-book-controller": "6.0.3-preview-b5bc200b",
  "@metamask-previews/announcement-controller": "7.0.3-preview-b5bc200b",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-b5bc200b",
  "@metamask-previews/approval-controller": "7.1.3-preview-b5bc200b",
  "@metamask-previews/assets-controllers": "60.0.0-preview-b5bc200b",
  "@metamask-previews/base-controller": "8.0.1-preview-b5bc200b",
  "@metamask-previews/bridge-controller": "20.0.0-preview-b5bc200b",
  "@metamask-previews/bridge-status-controller": "17.0.0-preview-b5bc200b",
  "@metamask-previews/build-utils": "3.0.3-preview-b5bc200b",
  "@metamask-previews/chain-agnostic-permission": "0.5.0-preview-b5bc200b",
  "@metamask-previews/composable-controller": "11.0.0-preview-b5bc200b",
  "@metamask-previews/controller-utils": "11.7.0-preview-b5bc200b",
  "@metamask-previews/delegation-controller": "0.1.0-preview-b5bc200b",
  "@metamask-previews/earn-controller": "0.12.0-preview-b5bc200b",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-b5bc200b",
  "@metamask-previews/ens-controller": "16.0.0-preview-b5bc200b",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-b5bc200b",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-b5bc200b",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-b5bc200b",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-b5bc200b",
  "@metamask-previews/keyring-controller": "21.0.5-preview-b5bc200b",
  "@metamask-previews/logging-controller": "6.0.4-preview-b5bc200b",
  "@metamask-previews/message-manager": "12.0.1-preview-b5bc200b",
  "@metamask-previews/multichain": "4.0.0-preview-b5bc200b",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-b5bc200b",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-b5bc200b",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-b5bc200b",
  "@metamask-previews/name-controller": "8.0.3-preview-b5bc200b",
  "@metamask-previews/network-controller": "23.3.0-preview-b5bc200b",
  "@metamask-previews/notification-services-controller": "6.0.1-preview-b5bc200b",
  "@metamask-previews/permission-controller": "11.0.6-preview-b5bc200b",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-b5bc200b",
  "@metamask-previews/phishing-controller": "12.5.0-preview-b5bc200b",
  "@metamask-previews/polling-controller": "13.0.0-preview-b5bc200b",
  "@metamask-previews/preferences-controller": "17.0.0-preview-b5bc200b",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-b5bc200b",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-b5bc200b",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-b5bc200b",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-b5bc200b",
  "@metamask-previews/sample-controllers": "0.1.0-preview-b5bc200b",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-b5bc200b",
  "@metamask-previews/signature-controller": "27.1.0-preview-b5bc200b",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-b5bc200b",
  "@metamask-previews/transaction-controller": "54.4.0-preview-b5bc200b",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-b5bc200b"
}

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-7ee8396c",
  "@metamask-previews/address-book-controller": "6.0.3-preview-7ee8396c",
  "@metamask-previews/announcement-controller": "7.0.3-preview-7ee8396c",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-7ee8396c",
  "@metamask-previews/approval-controller": "7.1.3-preview-7ee8396c",
  "@metamask-previews/assets-controllers": "60.0.0-preview-7ee8396c",
  "@metamask-previews/base-controller": "8.0.1-preview-7ee8396c",
  "@metamask-previews/bridge-controller": "20.0.0-preview-7ee8396c",
  "@metamask-previews/bridge-status-controller": "17.0.0-preview-7ee8396c",
  "@metamask-previews/build-utils": "3.0.3-preview-7ee8396c",
  "@metamask-previews/chain-agnostic-permission": "0.5.0-preview-7ee8396c",
  "@metamask-previews/composable-controller": "11.0.0-preview-7ee8396c",
  "@metamask-previews/controller-utils": "11.7.0-preview-7ee8396c",
  "@metamask-previews/delegation-controller": "0.1.0-preview-7ee8396c",
  "@metamask-previews/earn-controller": "0.12.0-preview-7ee8396c",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-7ee8396c",
  "@metamask-previews/ens-controller": "16.0.0-preview-7ee8396c",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-7ee8396c",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-7ee8396c",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-7ee8396c",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-7ee8396c",
  "@metamask-previews/keyring-controller": "21.0.5-preview-7ee8396c",
  "@metamask-previews/logging-controller": "6.0.4-preview-7ee8396c",
  "@metamask-previews/message-manager": "12.0.1-preview-7ee8396c",
  "@metamask-previews/multichain": "4.0.0-preview-7ee8396c",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-7ee8396c",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-7ee8396c",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-7ee8396c",
  "@metamask-previews/name-controller": "8.0.3-preview-7ee8396c",
  "@metamask-previews/network-controller": "23.3.0-preview-7ee8396c",
  "@metamask-previews/notification-services-controller": "6.0.1-preview-7ee8396c",
  "@metamask-previews/permission-controller": "11.0.6-preview-7ee8396c",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-7ee8396c",
  "@metamask-previews/phishing-controller": "12.5.0-preview-7ee8396c",
  "@metamask-previews/polling-controller": "13.0.0-preview-7ee8396c",
  "@metamask-previews/preferences-controller": "17.0.0-preview-7ee8396c",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-7ee8396c",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-7ee8396c",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-7ee8396c",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-7ee8396c",
  "@metamask-previews/sample-controllers": "0.1.0-preview-7ee8396c",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-7ee8396c",
  "@metamask-previews/signature-controller": "27.1.0-preview-7ee8396c",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-7ee8396c",
  "@metamask-previews/transaction-controller": "54.4.0-preview-7ee8396c",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-7ee8396c"
}

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@sahar-fehri sahar-fehri marked this pull request as ready for review May 6, 2025 07:52
@sahar-fehri sahar-fehri requested a review from a team as a code owner May 6, 2025 07:52
@sahar-fehri sahar-fehri changed the title fix: improve multichainTokenBalances controller state upates fix: improve multichainTokenBalances and multichainAssetsRates controller state upates May 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-de12a032",
  "@metamask-previews/address-book-controller": "6.0.3-preview-de12a032",
  "@metamask-previews/announcement-controller": "7.0.3-preview-de12a032",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-de12a032",
  "@metamask-previews/approval-controller": "7.1.3-preview-de12a032",
  "@metamask-previews/assets-controllers": "60.0.0-preview-de12a032",
  "@metamask-previews/base-controller": "8.0.1-preview-de12a032",
  "@metamask-previews/bridge-controller": "20.0.0-preview-de12a032",
  "@metamask-previews/bridge-status-controller": "17.0.0-preview-de12a032",
  "@metamask-previews/build-utils": "3.0.3-preview-de12a032",
  "@metamask-previews/chain-agnostic-permission": "0.5.0-preview-de12a032",
  "@metamask-previews/composable-controller": "11.0.0-preview-de12a032",
  "@metamask-previews/controller-utils": "11.7.0-preview-de12a032",
  "@metamask-previews/delegation-controller": "0.1.0-preview-de12a032",
  "@metamask-previews/earn-controller": "0.12.0-preview-de12a032",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-de12a032",
  "@metamask-previews/ens-controller": "16.0.0-preview-de12a032",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-de12a032",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-de12a032",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-de12a032",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-de12a032",
  "@metamask-previews/keyring-controller": "21.0.5-preview-de12a032",
  "@metamask-previews/logging-controller": "6.0.4-preview-de12a032",
  "@metamask-previews/message-manager": "12.0.1-preview-de12a032",
  "@metamask-previews/multichain": "4.0.0-preview-de12a032",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-de12a032",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-de12a032",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-de12a032",
  "@metamask-previews/name-controller": "8.0.3-preview-de12a032",
  "@metamask-previews/network-controller": "23.3.0-preview-de12a032",
  "@metamask-previews/notification-services-controller": "6.0.1-preview-de12a032",
  "@metamask-previews/permission-controller": "11.0.6-preview-de12a032",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-de12a032",
  "@metamask-previews/phishing-controller": "12.5.0-preview-de12a032",
  "@metamask-previews/polling-controller": "13.0.0-preview-de12a032",
  "@metamask-previews/preferences-controller": "17.0.0-preview-de12a032",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-de12a032",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-de12a032",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-de12a032",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-de12a032",
  "@metamask-previews/sample-controllers": "0.1.0-preview-de12a032",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-de12a032",
  "@metamask-previews/signature-controller": "27.1.0-preview-de12a032",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-de12a032",
  "@metamask-previews/transaction-controller": "54.4.0-preview-de12a032",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-de12a032"
}

@sahar-fehri sahar-fehri mentioned this pull request May 6, 2025
Draft
7 tasks
@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-fa22a478",
  "@metamask-previews/address-book-controller": "6.0.3-preview-fa22a478",
  "@metamask-previews/announcement-controller": "7.0.3-preview-fa22a478",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-fa22a478",
  "@metamask-previews/approval-controller": "7.1.3-preview-fa22a478",
  "@metamask-previews/assets-controllers": "60.0.0-preview-fa22a478",
  "@metamask-previews/base-controller": "8.0.1-preview-fa22a478",
  "@metamask-previews/bridge-controller": "20.0.0-preview-fa22a478",
  "@metamask-previews/bridge-status-controller": "17.0.0-preview-fa22a478",
  "@metamask-previews/build-utils": "3.0.3-preview-fa22a478",
  "@metamask-previews/chain-agnostic-permission": "0.5.0-preview-fa22a478",
  "@metamask-previews/composable-controller": "11.0.0-preview-fa22a478",
  "@metamask-previews/controller-utils": "11.7.0-preview-fa22a478",
  "@metamask-previews/delegation-controller": "0.1.0-preview-fa22a478",
  "@metamask-previews/earn-controller": "0.12.0-preview-fa22a478",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-fa22a478",
  "@metamask-previews/ens-controller": "16.0.0-preview-fa22a478",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-fa22a478",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-fa22a478",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-fa22a478",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-fa22a478",
  "@metamask-previews/keyring-controller": "21.0.5-preview-fa22a478",
  "@metamask-previews/logging-controller": "6.0.4-preview-fa22a478",
  "@metamask-previews/message-manager": "12.0.1-preview-fa22a478",
  "@metamask-previews/multichain": "4.0.0-preview-fa22a478",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-fa22a478",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-fa22a478",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-fa22a478",
  "@metamask-previews/name-controller": "8.0.3-preview-fa22a478",
  "@metamask-previews/network-controller": "23.3.0-preview-fa22a478",
  "@metamask-previews/notification-services-controller": "6.0.1-preview-fa22a478",
  "@metamask-previews/permission-controller": "11.0.6-preview-fa22a478",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-fa22a478",
  "@metamask-previews/phishing-controller": "12.5.0-preview-fa22a478",
  "@metamask-previews/polling-controller": "13.0.0-preview-fa22a478",
  "@metamask-previews/preferences-controller": "17.0.0-preview-fa22a478",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-fa22a478",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-fa22a478",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-fa22a478",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-fa22a478",
  "@metamask-previews/sample-controllers": "0.1.0-preview-fa22a478",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-fa22a478",
  "@metamask-previews/signature-controller": "27.1.0-preview-fa22a478",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-fa22a478",
  "@metamask-previews/transaction-controller": "54.4.0-preview-fa22a478",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-fa22a478"
}

ccharly
ccharly reviewed May 6, 2025
View reviewed changes
@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "28.0.0-preview-64413dce",
  "@metamask-previews/address-book-controller": "6.0.3-preview-64413dce",
  "@metamask-previews/announcement-controller": "7.0.3-preview-64413dce",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-64413dce",
  "@metamask-previews/approval-controller": "7.1.3-preview-64413dce",
  "@metamask-previews/assets-controllers": "61.0.0-preview-64413dce",
  "@metamask-previews/base-controller": "8.0.1-preview-64413dce",
  "@metamask-previews/bridge-controller": "21.0.0-preview-64413dce",
  "@metamask-previews/bridge-status-controller": "18.0.0-preview-64413dce",
  "@metamask-previews/build-utils": "3.0.3-preview-64413dce",
  "@metamask-previews/chain-agnostic-permission": "0.6.0-preview-64413dce",
  "@metamask-previews/composable-controller": "11.0.0-preview-64413dce",
  "@metamask-previews/controller-utils": "11.7.0-preview-64413dce",
  "@metamask-previews/delegation-controller": "0.2.0-preview-64413dce",
  "@metamask-previews/earn-controller": "0.13.0-preview-64413dce",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-64413dce",
  "@metamask-previews/ens-controller": "16.0.0-preview-64413dce",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-64413dce",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-64413dce",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-64413dce",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-64413dce",
  "@metamask-previews/keyring-controller": "21.0.6-preview-64413dce",
  "@metamask-previews/logging-controller": "6.0.4-preview-64413dce",
  "@metamask-previews/message-manager": "12.0.1-preview-64413dce",
  "@metamask-previews/multichain": "4.0.0-preview-64413dce",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-64413dce",
  "@metamask-previews/multichain-network-controller": "0.6.0-preview-64413dce",
  "@metamask-previews/multichain-transactions-controller": "0.10.0-preview-64413dce",
  "@metamask-previews/name-controller": "8.0.3-preview-64413dce",
  "@metamask-previews/network-controller": "23.3.0-preview-64413dce",
  "@metamask-previews/notification-services-controller": "7.0.0-preview-64413dce",
  "@metamask-previews/permission-controller": "11.0.6-preview-64413dce",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-64413dce",
  "@metamask-previews/phishing-controller": "12.5.0-preview-64413dce",
  "@metamask-previews/polling-controller": "13.0.0-preview-64413dce",
  "@metamask-previews/preferences-controller": "17.0.0-preview-64413dce",
  "@metamask-previews/profile-sync-controller": "13.0.0-preview-64413dce",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-64413dce",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-64413dce",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-64413dce",
  "@metamask-previews/sample-controllers": "0.1.0-preview-64413dce",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-64413dce",
  "@metamask-previews/signature-controller": "28.0.0-preview-64413dce",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-64413dce",
  "@metamask-previews/transaction-controller": "55.0.0-preview-64413dce",
  "@metamask-previews/user-operation-controller": "34.0.0-preview-64413dce"
}

ccharly
ccharly reviewed May 6, 2025
View reviewed changes
@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "28.0.0-preview-ace5334a",
  "@metamask-previews/address-book-controller": "6.0.3-preview-ace5334a",
  "@metamask-previews/announcement-controller": "7.0.3-preview-ace5334a",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-ace5334a",
  "@metamask-previews/approval-controller": "7.1.3-preview-ace5334a",
  "@metamask-previews/assets-controllers": "61.0.0-preview-ace5334a",
  "@metamask-previews/base-controller": "8.0.1-preview-ace5334a",
  "@metamask-previews/bridge-controller": "21.0.0-preview-ace5334a",
  "@metamask-previews/bridge-status-controller": "18.0.0-preview-ace5334a",
  "@metamask-previews/build-utils": "3.0.3-preview-ace5334a",
  "@metamask-previews/chain-agnostic-permission": "0.6.0-preview-ace5334a",
  "@metamask-previews/composable-controller": "11.0.0-preview-ace5334a",
  "@metamask-previews/controller-utils": "11.7.0-preview-ace5334a",
  "@metamask-previews/delegation-controller": "0.2.0-preview-ace5334a",
  "@metamask-previews/earn-controller": "0.13.0-preview-ace5334a",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-ace5334a",
  "@metamask-previews/ens-controller": "16.0.0-preview-ace5334a",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-ace5334a",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-ace5334a",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-ace5334a",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-ace5334a",
  "@metamask-previews/keyring-controller": "21.0.6-preview-ace5334a",
  "@metamask-previews/logging-controller": "6.0.4-preview-ace5334a",
  "@metamask-previews/message-manager": "12.0.1-preview-ace5334a",
  "@metamask-previews/multichain": "4.0.0-preview-ace5334a",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-ace5334a",
  "@metamask-previews/multichain-network-controller": "0.6.0-preview-ace5334a",
  "@metamask-previews/multichain-transactions-controller": "0.10.0-preview-ace5334a",
  "@metamask-previews/name-controller": "8.0.3-preview-ace5334a",
  "@metamask-previews/network-controller": "23.3.0-preview-ace5334a",
  "@metamask-previews/notification-services-controller": "7.0.0-preview-ace5334a",
  "@metamask-previews/permission-controller": "11.0.6-preview-ace5334a",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-ace5334a",
  "@metamask-previews/phishing-controller": "12.5.0-preview-ace5334a",
  "@metamask-previews/polling-controller": "13.0.0-preview-ace5334a",
  "@metamask-previews/preferences-controller": "17.0.0-preview-ace5334a",
  "@metamask-previews/profile-sync-controller": "13.0.0-preview-ace5334a",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-ace5334a",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-ace5334a",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-ace5334a",
  "@metamask-previews/sample-controllers": "0.1.0-preview-ace5334a",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-ace5334a",
  "@metamask-previews/signature-controller": "28.0.0-preview-ace5334a",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-ace5334a",
  "@metamask-previews/transaction-controller": "55.0.0-preview-ace5334a",
  "@metamask-previews/user-operation-controller": "34.0.0-preview-ace5334a"
}

@ccharly ccharly changed the title fix: improve multichainTokenBalances and multichainAssetsRates controller state upates fix: improve multichainTokenBalances and multichainAssetsRates controller state updates May 6, 2025
ccharly
ccharly previously approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making all those changes 😄

@sahar-fehri
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "28.0.0-preview-dc59ef6a",
  "@metamask-previews/address-book-controller": "6.0.3-preview-dc59ef6a",
  "@metamask-previews/announcement-controller": "7.0.3-preview-dc59ef6a",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-dc59ef6a",
  "@metamask-previews/approval-controller": "7.1.3-preview-dc59ef6a",
  "@metamask-previews/assets-controllers": "61.0.0-preview-dc59ef6a",
  "@metamask-previews/base-controller": "8.0.1-preview-dc59ef6a",
  "@metamask-previews/bridge-controller": "21.0.0-preview-dc59ef6a",
  "@metamask-previews/bridge-status-controller": "18.0.0-preview-dc59ef6a",
  "@metamask-previews/build-utils": "3.0.3-preview-dc59ef6a",
  "@metamask-previews/chain-agnostic-permission": "0.6.0-preview-dc59ef6a",
  "@metamask-previews/composable-controller": "11.0.0-preview-dc59ef6a",
  "@metamask-previews/controller-utils": "11.7.0-preview-dc59ef6a",
  "@metamask-previews/delegation-controller": "0.2.0-preview-dc59ef6a",
  "@metamask-previews/earn-controller": "0.13.0-preview-dc59ef6a",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-dc59ef6a",
  "@metamask-previews/ens-controller": "16.0.0-preview-dc59ef6a",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-dc59ef6a",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-dc59ef6a",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-dc59ef6a",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-dc59ef6a",
  "@metamask-previews/keyring-controller": "21.0.6-preview-dc59ef6a",
  "@metamask-previews/logging-controller": "6.0.4-preview-dc59ef6a",
  "@metamask-previews/message-manager": "12.0.1-preview-dc59ef6a",
  "@metamask-previews/multichain": "4.0.0-preview-dc59ef6a",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-dc59ef6a",
  "@metamask-previews/multichain-network-controller": "0.6.0-preview-dc59ef6a",
  "@metamask-previews/multichain-transactions-controller": "0.10.0-preview-dc59ef6a",
  "@metamask-previews/name-controller": "8.0.3-preview-dc59ef6a",
  "@metamask-previews/network-controller": "23.3.0-preview-dc59ef6a",
  "@metamask-previews/notification-services-controller": "7.0.0-preview-dc59ef6a",
  "@metamask-previews/permission-controller": "11.0.6-preview-dc59ef6a",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-dc59ef6a",
  "@metamask-previews/phishing-controller": "12.5.0-preview-dc59ef6a",
  "@metamask-previews/polling-controller": "13.0.0-preview-dc59ef6a",
  "@metamask-previews/preferences-controller": "17.0.0-preview-dc59ef6a",
  "@metamask-previews/profile-sync-controller": "13.0.0-preview-dc59ef6a",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-dc59ef6a",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-dc59ef6a",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-dc59ef6a",
  "@metamask-previews/sample-controllers": "0.1.0-preview-dc59ef6a",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-dc59ef6a",
  "@metamask-previews/signature-controller": "28.0.0-preview-dc59ef6a",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-dc59ef6a",
  "@metamask-previews/transaction-controller": "55.0.0-preview-dc59ef6a",
  "@metamask-previews/user-operation-controller": "34.0.0-preview-dc59ef6a"
}

@sahar-fehri sahar-fehri mentioned this pull request May 6, 2025
Open
7 tasks
bergarces
bergarces approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@bergarces bergarces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccharly ccharly ccharly approved these changes

@bergarces bergarces bergarces approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sahar-fehri @ccharly @bergarces @Prithpal-Sooriya