chore: use keccak256 from ethereum-cryptography #28170
Open
+127
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
added
dependencies
8 tasks
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
from
344f094 to
663b589
Compare
7 tasks
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
2 times, most recently
from
89b2759 to
1f4eeb0
Compare
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
from
1f4eeb0 to
89db810
Compare
10 tasks
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
15 times, most recently
from
bd1ca09 to
508f025
Compare
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
2 times, most recently
from
7621574 to
374ccbf
Compare
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
2 times, most recently
from
04d97e2 to
e9b5bea
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
## **Description** - remove redundant resolutions entries - `ethereumjs-util` v5 is no longer present - fix: use `BN` from bn.js (v5) instead of `ethereumjs-util` (deprecated version) [](https://codespaces.new/MetaMask/metamask-extension/pull/28146?quickstart=1) ## **Related issues** #### Blocking - #28169 - #28171 - #28170 ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
2 times, most recently
from
ab339f5 to
fd1bfc8
Compare
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
8 times, most recently
from
479897b to
e3a89c6
Compare
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
from
e3a89c6 to
ce17b12
Compare
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
from
e815f24 to
31ad53c
Compare
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
2 times, most recently
from
d9acb20 to
faa4608
Compare
legobeat
force-pushed
the
deps-ethereumjs-util-keccak
branch
from
faa4608 to
87ef2cf
Compare
leotm
reviewed
Mar 11, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/28146?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Legacy
ethereum-utilis deprecated and uses a simialrly legacy version of keccak. This replaces usage withethereum-cryptography(@noble/hashes).Related issues
Blocked by
Blocking
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist