chore: use sha256 from @noble/hashes #28171
Open
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
added
dependencies
legobeat
force-pushed
the
deps-etheremjs-util-sha256
branch
3 times, most recently
from
be1b720 to
14a6791
Compare
This was referenced Oct 30, 2024
legobeat
force-pushed
the
deps-etheremjs-util-sha256
branch
15 times, most recently
from
7c5ad24 to
0e605c2
Compare
legobeat
force-pushed
the
deps-etheremjs-util-sha256
branch
3 times, most recently
from
a163299 to
d85040d
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
## **Description** - remove redundant resolutions entries - `ethereumjs-util` v5 is no longer present - fix: use `BN` from bn.js (v5) instead of `ethereumjs-util` (deprecated version) [](https://codespaces.new/MetaMask/metamask-extension/pull/28146?quickstart=1) ## **Related issues** #### Blocking - #28169 - #28171 - #28170 ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
legobeat
force-pushed
the
deps-etheremjs-util-sha256
branch
from
d85040d to
be97ffe
Compare
legobeat
force-pushed
the
deps-etheremjs-util-sha256
branch
2 times, most recently
from
6de9491 to
5d175cd
Compare
legobeat
force-pushed
the
deps-etheremjs-util-sha256
branch
2 times, most recently
from
5a71630 to
ef488ce
Compare
legobeat
force-pushed
the
deps-etheremjs-util-sha256
branch
from
ef488ce to
53fc28c
Compare
legobeat
force-pushed
the
deps-etheremjs-util-sha256
branch
from
53fc28c to
e9fc527
Compare
MeantwoBee
reviewed
Apr 13, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/28146?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace usage of sha256 implementation from deprecated legacy
ethereumjs-utilwith@noble/hashes.Related issues
Blocked by
Blocking
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist