Skip to content

fix: use BN from bn.js instead of ethereumjs-util #28146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 29, 2024

Description

  • remove redundant resolutions entries
    • ethereumjs-util v5 is no longer present
  • fix: use BN from bn.js (v5) instead of ethereumjs-util (deprecated version)

Open in GitHub Codespaces

Related issues

Blocking

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added type-bug Something isn't working dependencies Pull requests that update a dependency file team-security labels Oct 29, 2024
@legobeat legobeat force-pushed the deps-ethereumjs-util-bn branch from 181e60b to a1e80e6 Compare October 29, 2024 11:38
@legobeat legobeat marked this pull request as ready for review October 29, 2024 11:45
@legobeat legobeat requested a review from a team as a code owner October 29, 2024 11:45
@legobeat legobeat force-pushed the deps-ethereumjs-util-bn branch 2 times, most recently from 5e66145 to f39b441 Compare October 30, 2024 00:35
@legobeat legobeat added the type-tech-debt Technical debt label Oct 30, 2024
@legobeat legobeat force-pushed the deps-ethereumjs-util-bn branch from 124bd06 to cbf73fd Compare November 3, 2024 01:53
@legobeat legobeat force-pushed the deps-ethereumjs-util-bn branch 3 times, most recently from e3251c4 to 895fdc5 Compare November 4, 2024 21:57
@legobeat legobeat force-pushed the deps-ethereumjs-util-bn branch 11 times, most recently from 640984a to 3ba4cb1 Compare November 6, 2024 10:44
@legobeat legobeat force-pushed the deps-ethereumjs-util-bn branch from 57dd181 to 7a14db2 Compare November 23, 2024 08:44
@HowardBraham HowardBraham added this pull request to the merge queue Nov 26, 2024
Merged via the queue into MetaMask:develop with commit dadeac9 Nov 26, 2024
74 of 75 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file external-contributor team-security type-bug Something isn't working type-tech-debt Technical debt
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants