refactor(engine): wire TransactionController into @metamask/wallet init

[matthewwalsh0]

Description

Moves TransactionController construction from the legacy Engine init registry into the @metamask/wallet-owned wallet-init flow, mirroring extension PR #43182.

• @metamask/wallet now owns the TC's controller messenger and persisted state
• Mobile supplies the client-specific instance options + event listeners
• Access via wallet.getInstance('TransactionController') instead of the legacy messengerClientsByName registry
• Mobile-specific behaviour preserved: getState() + selectShouldUseSmartTransaction, isAutomaticGasFeeUpdateEnabled, metrics / notification / money-account event handlers
• Bumps @metamask/wallet 6→7, @metamask/transaction-controller to 68.4.0, @metamask/messenger to 2.0.0

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Transaction submission after wallet-init refactor

  Scenario: user sends a transaction
    Given a wallet with funds on a supported network
    When user creates and confirms a send transaction
    Then the transaction is submitted and reaches a confirmed state

  Scenario: user submits a smart transaction
    Given smart transactions are enabled for the current chain
    When user confirms a transaction
    Then the transaction is submitted via the smart transaction path

Screenshots/Recordings

N/A

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

High Risk
This changes how the transaction lifecycle controller is constructed and accessed on the critical send/confirm/publish path; regressions could break submission, smart transactions, or metrics without obvious UI failures.

Overview
TransactionController is no longer created through the Engine’s MessengerClientInit registry. Construction and persisted state move to @metamask/wallet, with mobile supplying transactionController instance options and setupTransactionControllerListeners during initializeWallet.

Engine drops TransactionController from the init map and messenger registry; it resolves the controller via this.#wallet.getInstance('TransactionController') instead of messengerClientsByName. The old TransactionControllerInit module and its large init test file are removed in favor of wallet-init/instance-options/transaction-controller and focused unit tests.

Mobile-specific behavior is preserved in the new builders: publish hooks (via a messenger-backed getTransactionController proxy), gas-fee helpers, EIP-7702 token gating, and metrics / notification / money-account event subscriptions. The init messenger lives under wallet-init/messengers (controller messenger wiring removed from Engine messengers index), with extra delegated actions for nonce lock and atomic batch support.

Dependencies: @metamask/wallet ^6 → ^7.0.1, @metamask/connectivity-controller ^0.3.0.

^{Reviewed by Cursor Bugbot for commit 6067326. Bugbot is set up for automated code reviews on this repo. Configure here.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​connectivity-controller@​0.3.0
	npm/​@​metamask/​wallet@​6.0.0 ⏵ 7.0.1	+1		+1	+1

View full report

[socket-security]

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.
• Pre-merge author checklist has only 5 of the required 8 items. Every checklist row must be present and consciously checked — do not delete rows.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[FrederikBolding]

Is this downgrade intentional?

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 3e739cb. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
• Selected Performance tags: @PerformanceSwaps
• Risk Level: high
• AI Confidence: 100%

click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/connectivity-controller. Running all tests.

Performance Test Selection:
The TransactionController architectural refactoring (moved to @metamask/wallet Wallet-managed initialization, major version bump ^6→^7) could affect transaction execution timing and performance. The @PerformanceSwaps tag is most relevant as swap flows are the most performance-sensitive transaction flows. Other performance tags like @PerformanceLaunch and @PerformanceLogin could also be affected by the wallet initialization change, but the primary concern is transaction execution performance. Selecting @PerformanceSwaps as the most directly impacted performance scenario.

View GitHub Actions results

[sonarqubecloud]

Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 80%)
14.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[codecov-commenter]

Codecov Report

❌ Patch coverage is 82.60870% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.37%. Comparing base (65eb9a3) to head (6067326).
⚠️ Report is 31 commits behind head on main.

Files with missing lines	Patch %	Lines
...et-init/instance-options/transaction-controller.ts	80.48%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #32937      +/-   ##
==========================================
+ Coverage   84.34%   84.37%   +0.03%     
==========================================
  Files        6115     6132      +17     
  Lines      163209   163725     +516     
  Branches    39822    39924     +102     
==========================================
+ Hits       137651   138143     +492     
- Misses      16047    16070      +23     
- Partials     9511     9512       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

❌ 1 test failed · 2 tests · 1 device

📱 Devices tested (1)

Android: Google Pixel 8 Pro (v14.0)

❌ Failed Tests (1)

@swap-bridge-dev-team

Test	Platform	Device	Reason	Recording
Cross-chain swap flow - ETH to SOL - 50+ accounts, SRP 1 + SRP 2 + SRP 3	Android	Google Pixel 8 Pro (v14.0)	Test error	📹 Watch

✅ Passed Tests (1)

Test	Platform	Device	Duration	Team	Recording
Swap flow - ETH to LINK, SRP 1 + SRP 2 + SRP 3	Android	Google Pixel 8 Pro (v14.0)	2.55s	@swap-bridge-dev-team	📹 Watch

---

Branch: feat/wallet-wire-transaction-controller · Build: Normal · Commit: 5d82359 · View full run