Full run e2e on every branch#36
Merged
Merged
Conversation
jeffsmale90
force-pushed
the
chore/e2e-fullrun
branch
from
57e051b to
58305a7
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jeffsmale90
force-pushed
the
chore/e2e-fullrun
branch
from
92cfb71 to
cb4f574
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jeffsmale90
force-pushed
the
chore/e2e-fullrun
branch
from
cb4f574 to
57f5187
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…ng logic, remove explicit turbo cache dir
jeffsmale90
force-pushed
the
chore/e2e-fullrun
branch
from
57f5187 to
b10e40e
Compare
jeffsmale90
force-pushed
the
chore/e2e-fullrun
branch
2 times, most recently
from
87be5a2 to
82ae28b
Compare
…nutes. Fix issue where dependency is marked as unavailable even when it's responding, if the method is not supported.
jeffsmale90
force-pushed
the
chore/e2e-fullrun
branch
from
82ae28b to
db7181a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…40) Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: jeff.smale <jeff.smale@consensys.net>
hanzel98
reviewed
Jul 29, 2025
hanzel98
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Run full e2e tests on all branches.
🔄 What Changed?
This PR removes the distinction between main and smoke tests, running full tests on each branch.
🚀 Why?
Previously e2e tests required ~25 minutes to complete, in order to mitigate this, we split the tests into smoke tests (run on PR branches) and full tests (run in main and release branches).
Unfortunately we have seen false negatives resulting in failures being merged into main branch
We have improved the test performance such that they complete in ~4-5 minutes. In reality the entire workflow is taking approx 10 minutes.
🧪 How to Test?
Describe how to test these changes:
Ensure Full tests run on this branch, and once merged to main.
Check e2e test runtime, and ensure it's sufficiently fast to run on every branch.