Status Communications - #84
Merged
Merged
Conversation
This was referenced May 30, 2026
zhengtaocui
reviewed
Jun 1, 2026
| try: | ||
| raise ValueError(f"Unexpected run_type {self.run_type} for build_calib_realization. Must be `calibration`.") | ||
| except ValueError as e: | ||
| logging.critical(e) |
There was a problem hiding this comment.
Will this message be logged by EWTS as well?
Author
There was a problem hiding this comment.
Good question, I just tested and no, the raw logging. calls do not route through EWTS. I will check with the team on why some of the logging. calls were not converted to logger. (which is routed through EWTS) when EWTS was added to this repository.
I would like to go ahead and merge this now as-is since it includes the minimal changes needed to enable the status reporting (a few payload messages and exposure of property log_file_path for the listener). We can revisit logging generally, in a later PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Payloads related to: https://github.com/NGWPC/nwm-rte/pull/84And exposes log file paths to support.
This should be reviewed in conjunction with these PRs of other repositories:
https://github.com/NGWPC/nwm-rte/pull/84
NGWPC/nwm-fcst-mgr#23
NGWPC/ngen-forcing#170