Jwade ngwpc 10211 wcoss - #23
Merged
Merged
Conversation
jswade-rtx
force-pushed
the
jwade_NGWPC-10211_wcoss
branch
from
April 29, 2026 13:24
5557435 to
9f1e356
Compare
jswade-rtx
force-pushed
the
jwade_NGWPC-10211_wcoss
branch
from
April 29, 2026 17:12
9f1e356 to
201b1fc
Compare
…d during manual context management
This was referenced May 30, 2026
|
This should be reviewed in conjunction with these PRs of other repositories: https://github.com/NGWPC/nwm-rte/pull/84 |
12 tasks
|
It can run hindcast and forecast. How about the default run? Can it run with state saving and warm restart? |
Please see: https://github.com/NGWPC/nwm-rte/pull/85 |
|
It looks good to me. |
zhengtaocui
approved these changes
Jun 2, 2026
|
The SIGTERM handler was simple enough to add to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor forecast manager to remove ensemble workflow and add no_valid mode for WCOSS., enabling the fcst-mgr to run real-time forecast configurations using the default/regionalization run types instead of only the existing calibration/validation/forecast workflow.
Changes
Lagged Ensemble Removal
The lagged ensemble workflow has been removed from the fcst-mgr to make it compatible with WCOSS parallel execution and to allow checkpoint restarting. Lagged ensembles are now set up by the msw-mgr directly, with each individual ensemble member submitted as a standalone forecast run using the
run_forecastworkflow.no_validFlagAdded a
no_validflag to the fcst-mgr to support two execution modes:no_valid=False(default): Existing behavior, the fcst-mgr runsf rom an existing validation run, with the validation configuration file supplied via the optionalvalid_yamlargumentno_valid=True: New WCOSS compliant mode, allowing the fcst-mgr to execute a forecast run for a default/regionalization run type where no validation yaml eixts.