Skip to content

Jwade ngwpc 10211 wcoss - #23

Merged
mxkpp merged 16 commits into
developmentfrom
jwade_NGWPC-10211_wcoss
Jun 2, 2026
Merged

Jwade ngwpc 10211 wcoss#23
mxkpp merged 16 commits into
developmentfrom
jwade_NGWPC-10211_wcoss

Conversation

@jswade-rtx

Copy link
Copy Markdown

Refactor forecast manager to remove ensemble workflow and add no_valid mode for WCOSS., enabling the fcst-mgr to run real-time forecast configurations using the default/regionalization run types instead of only the existing calibration/validation/forecast workflow.

Changes
Lagged Ensemble Removal
The lagged ensemble workflow has been removed from the fcst-mgr to make it compatible with WCOSS parallel execution and to allow checkpoint restarting. Lagged ensembles are now set up by the msw-mgr directly, with each individual ensemble member submitted as a standalone forecast run using the run_forecast workflow.

no_valid Flag
Added a no_valid flag to the fcst-mgr to support two execution modes:

  • no_valid=False (default): Existing behavior, the fcst-mgr runsf rom an existing validation run, with the validation configuration file supplied via the optional valid_yaml argument
  • no_valid=True: New WCOSS compliant mode, allowing the fcst-mgr to execute a forecast run for a default/regionalization run type where no validation yaml eixts.

@jswade-rtx
jswade-rtx force-pushed the jwade_NGWPC-10211_wcoss branch from 5557435 to 9f1e356 Compare April 29, 2026 13:24
@jswade-rtx
jswade-rtx force-pushed the jwade_NGWPC-10211_wcoss branch from 9f1e356 to 201b1fc Compare April 29, 2026 17:12
@mxkpp

mxkpp commented May 30, 2026

Copy link
Copy Markdown

This should be reviewed in conjunction with these PRs of other repositories:

https://github.com/NGWPC/nwm-rte/pull/84
NGWPC/nwm-msw-mgr#84
NGWPC/ngen-forcing#170

@mxkpp mxkpp mentioned this pull request May 30, 2026
12 tasks
@zhengtaocui

Copy link
Copy Markdown

It can run hindcast and forecast. How about the default run? Can it run with state saving and warm restart?

@mxkpp

mxkpp commented Jun 2, 2026

Copy link
Copy Markdown

It can run hindcast and forecast. How about the default run? Can it run with state saving and warm restart?

Please see: https://github.com/NGWPC/nwm-rte/pull/85

@zhengtaocui

Copy link
Copy Markdown

It looks good to me.

@mxkpp

mxkpp commented Jun 2, 2026

Copy link
Copy Markdown

The SIGTERM handler was simple enough to add to ForecastExecutionManager since the close() method was already fault-tolerant for running multiple times. It's there now. I tested it by having nwm-rte send a SIGTERM to itself after starting a realization.

@mxkpp
mxkpp merged commit 07c8d30 into development Jun 2, 2026
7 checks passed
@mxkpp
mxkpp deleted the jwade_NGWPC-10211_wcoss branch June 2, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants