Initial Status Communications - #84
Merged
Merged
Conversation
This was referenced May 29, 2026
…c subprocess call
… report them for run_default.py, run_forecast.py, and run_calibration.py.
… BaseModel to dataclass. Async ngen: add optional postprocess call, expose destructor (close).
…s for default, forecast, and calibration in VS Code debugger
…ows for default and calibration
…support the env var NGEN_LOG_TO_RTE=YES
…on handling, add optional timeout
…on and log parsing, remove support for arg quit_forecast_after_forcing_running.
… Add ewts to nwm-rte and use log calls instead of print.
…tests report json
mxkpp
force-pushed
the
maxkipp-status-comms
branch
from
May 30, 2026 00:08
2d03d61 to
e3f402c
Compare
zhengtaocui
reviewed
Jun 1, 2026
zhengtaocui
left a comment
zhengtaocui
left a comment
There was a problem hiding this comment.
My test run was successful and I see the captured logs by RTE. The location of the dumped log is currently in the current working directory. It would be better to move it to the temporary working directory passed by EcFlow or make it configurable.
I also have another comment about the async execution ngen. I'm not sure if it is a background process. Just want you know that background is not allowed in production.
Contributor
Author
|
Regarding the location of the logs, they currently go to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds collection of status communications via parsing of logs (and optional payloads within the logs) of nwm-msw-mgr, nwm-fcst-mgr, and ngen (and its MPI ranks and submodules) during ngen execution.
Also reports basic status of nwm-msw-mgr and nwm-fcst-mgr directly (without being dependent on reading their logs to discover their payloads).
Adds EWTS to nwm-rte.
Adds transmissions from nwm-rte, e.g. to support communication with ecFlow and other aspects of the operational environment.
Consolidates some log paths (for
docker build,docker run, and the nwm-rte and ngen runtime logs).This should be reviewed in conjunction with these PRs of other repositories:
NGWPC/nwm-msw-mgr#84
NGWPC/nwm-fcst-mgr#23
NGWPC/ngen-forcing#170