Remove defined-but-unused variables in cubed_sphere2ll.c. - #531
Closed
manfredsc wants to merge 2 commits into
Closed
Remove defined-but-unused variables in cubed_sphere2ll.c.#531manfredsc wants to merge 2 commits into
manfredsc wants to merge 2 commits into
Conversation
Unused variables tile_start and tile_end in function cubed_sphere2ll. Additionally, the function cubed_spherell2xy contains a lot of unused variables, but the function itself is unused and without prototype and seemingly unfinished. So comment this function as a whole. Alternatively, one could remove it, if it is clear that this function will not be finished one day.
This was referenced Jun 8, 2026
Closed
Collaborator
|
Closing in favor of #533 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused variables tile_start and tile_end in function cubed_sphere2ll.
Additionally, the function cubed_spherell2xy contains a lot of unused variables, but the function itself is unused and without prototype and seemingly unfinished.
So comment this function as a whole. Alternatively, one could remove it, if it is clear that this function will not be finished one day.
Closes #532.