Skip to content

Conversation

@mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Apr 3, 2025

Motivation

This PR is to formally define bands within DecompositionSeries as a formal neurodatatype FrequencyBandsTable.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Base automatically changed from electrode to nwb-schema-2.9.0 May 17, 2025 06:25
@rly
Copy link
Contributor

rly commented May 24, 2025

Update: this PR requires the latest changes in HDMF to be released. The plan is to release HDMF 4.1.0 next Tuesday. Some new warnings have also appeared in the test suite in this PR and need to be addressed.

@rly rly marked this pull request as ready for review May 28, 2025 19:13
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (nwb-schema-2.9.0@cb9627f). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             nwb-schema-2.9.0    #2063   +/-   ##
===================================================
  Coverage                    ?   94.93%           
===================================================
  Files                       ?       28           
  Lines                       ?     2801           
  Branches                    ?      716           
===================================================
  Hits                        ?     2659           
  Misses                      ?       87           
  Partials                    ?       55           
Flag Coverage Δ
integration 74.72% <88.46%> (?)
unit 84.64% <76.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rly
Copy link
Contributor

rly commented May 28, 2025

HDMF 4.1.0 is not yet available on conda-forge but will be soon. Since we are not merging into dev and this is blocking other PRs, I suggest we merge and keep and eye on the conda-based ros3 tests before merging nwb-schema-2.9.0 into dev.

@rly rly merged commit dd12871 into nwb-schema-2.9.0 May 28, 2025
19 of 25 checks passed
@rly rly deleted the bands branch May 28, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants