Skip to content

[18.0][MIG] product_tax_multicompany_default: Migration to 18.0#811

Closed
Qlasta wants to merge 20 commits intoOCA:18.0from
versada:18.0-mig-product-tax-multicompany-default
Closed

[18.0][MIG] product_tax_multicompany_default: Migration to 18.0#811
Qlasta wants to merge 20 commits intoOCA:18.0from
versada:18.0-mig-product-tax-multicompany-default

Conversation

@Qlasta
Copy link
Copy Markdown
Contributor

@Qlasta Qlasta commented Apr 2, 2025

No description provided.

@Qlasta Qlasta mentioned this pull request Apr 2, 2025
12 tasks
@Xino61122
Copy link
Copy Markdown
Contributor

Hello, could you do a rebase so we can test the migration?

Thank you 😊.

carlosdauden and others added 20 commits August 12, 2025 16:01
OCA Transbot updated translations from Transifex
[UPD] Update product_tax_multicompany_default.pot

[UPD] Update product_tax_multicompany_default.pot

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[ADD] icon.png
* Use TransactionCase instead of SavepointCase
* adapt create method for multi records
- Refactored some tests to use new_test_user and @users
- Added a new test to cover the workflow of the product Form
- Propagate button was ugly. It's prettier now.
- Add ability to filter products that have divergent cross-company taxes.
- Allow propagating massively.

@moduon MT-2586
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: multi-company-16.0/multi-company-16.0-product_tax_multicompany_default
Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-product_tax_multicompany_default/
… to other companies

This module extends the functionality of products and accounting to allow you
to propagate multi-company product accounts from the current company to all
other companies where you have access rights.

@moduon MT-2626
Currently translated at 100.0% (5 of 5 strings)

Translation: multi-company-16.0/multi-company-16.0-product_tax_multicompany_default
Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-product_tax_multicompany_default/it/
NOTE: It is necessary to use sudo in test because the account.group_account_manager group does not have permission to create products.
See odoo/odoo@5125748#r144593878
… expected scope.

 When a user has multiple companies selected and multiple taxes with the same name, searching can return more taxes outside the intended scope (sale or purchase). This commit adds a new explicit filter to type_tax_use to avoid retrieving incorrect taxes.
@Qlasta Qlasta force-pushed the 18.0-mig-product-tax-multicompany-default branch from 153376f to e2b5588 Compare August 12, 2025 13:01
@Qlasta
Copy link
Copy Markdown
Contributor Author

Qlasta commented Aug 12, 2025

@Xino61122, rebase done!

Copy link
Copy Markdown

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @Qlasta.

I was reviewed the migration but I found an error. I loggin with user demo, this user has access to 2 companies
image

And also the user has the group "Show Full Accounting Features"
image

When I'm creating the product, an error happens
image

If I choose both companies for the user, then I can create it. But in the older version I can create the product in a single user company.

@rafaelbn
Copy link
Copy Markdown
Member

/ocabot migration product_tax_multicompany_default

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Sorry @rafaelbn you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@Shide
Copy link
Copy Markdown
Contributor

Shide commented Aug 18, 2025

/ocabot migration product_tax_multicompany_default

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 18, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 18, 2025
22 tasks
@Qlasta
Copy link
Copy Markdown
Contributor Author

Qlasta commented Aug 19, 2025

@EmilioPascual, thank you! Will check that.

@Xino61122
Copy link
Copy Markdown
Contributor

Hello, have you been able to configure the permissions to resolve the conflict that @EmilioPascual encountered?

@EmilioPascual
Copy link
Copy Markdown

MT-11041 @moduon

Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 1, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 1, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 1, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 8, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 8, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 23, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 24, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 24, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 24, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 24, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 29, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
Xino61122 added a commit to moduon/multi-company that referenced this pull request Sep 30, 2025
This PR is a continuation of PR OCA#811.

This PR is for the migration of the product_tax_multicompany_default module, which is used to propagate taxes across multiple companies.

This commit makes changes so that it is not duplicated in the Sales Taxes form view, and removes the functionality when creating a new product in all companies, since Odoo 18 already does this.

@moduon MT-11041
@Xino61122
Copy link
Copy Markdown
Contributor

Hello @Qlasta, this PR can be closed, it has been resolved in the PR #873.
Thank you for your job 😄.

@Qlasta
Copy link
Copy Markdown
Contributor Author

Qlasta commented Oct 15, 2025

Thank you @Xino61122, understood, someone did a great job ☺️

@Qlasta Qlasta closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.