Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix error recovery crashing the app #15837

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jul 30, 2024

Closes RQA-2887

Overview

Woops (part 2), it's important to remember that first class object change refs every render cycle 😄 There were two spots that got me in trouble here:

  • Analytics. This issue wasn't caught on dev, because Mixpanel doesn't effectively work unless it's built with a MIXPANEL_ID, which doesn't happen in dev.
  • Takeover logic. This one was new enough that probably no one has used the newest edge until QA got to it first. I'm not entirely sure why I didn't see this when testing, but I can consistently repro the issue and fix now, so it seems this was in fact half the problem.

I also did a general useEffect audit in ErrorRecoveryFlows and fixed one less-critical mistake.

Test Plan and Hands on Testing

  • Built the app and ran it - found here, verifying that the app doesn't crash during ER now.

Changelog

  • Fixed the robot crashing when interacting with error recovery.

Risk assessment

  • low with the testing

@mjhuff mjhuff requested a review from a team July 30, 2024 17:42
@mjhuff mjhuff force-pushed the app_fix-crashing-er branch 2 times, most recently from 559dc22 to 7f52cab Compare July 30, 2024 18:56
@mjhuff mjhuff requested review from TamarZanzouri and sfoster1 and removed request for a team July 30, 2024 19:24
@mjhuff mjhuff marked this pull request as ready for review July 30, 2024 19:25
@mjhuff mjhuff requested a review from a team as a code owner July 30, 2024 19:25
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug log

@mjhuff mjhuff requested a review from sfoster1 July 30, 2024 20:07
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mjhuff mjhuff merged commit 36a7501 into edge Jul 31, 2024
20 checks passed
@mjhuff mjhuff deleted the app_fix-crashing-er branch July 31, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants