fix(app): fix error recovery crashing the app #15837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-2887
Overview
Woops (part 2), it's important to remember that first class object change refs every render cycle 😄 There were two spots that got me in trouble here:
MIXPANEL_ID
, which doesn't happen in dev.edge
until QA got to it first. I'm not entirely sure why I didn't see this when testing, but I can consistently repro the issue and fix now, so it seems this was in fact half the problem.I also did a general
useEffect
audit inErrorRecoveryFlows
and fixed one less-critical mistake.Test Plan and Hands on Testing
Changelog
Risk assessment