fix: xml formatting matches the pretty-print lxml setting #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EzraBrooks
requested changes
Apr 3, 2025
Comment on lines
84
to
85
| # Use Prettier to lint XML files because, well.. its rules are prettier than most linters, as the name implies. | ||
| # Also we use it in the UI, so it's familiar. |
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <?xml version='1.0' encoding='utf-8'?> | |||
There was a problem hiding this comment.
An inconsistency is being introduced in quote style, specifically in XML prologues. Let's hunt this down
There was a problem hiding this comment.
Looks like https://github.com/efrecon/pre-commit-hook-lxml?tab=readme-ov-file#cli-options can configure the declaration to use double quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the diffs here are just syncing to the new REST API xml format and one change in our pre-commit settings