Skip to content

Space satellite sim camera calibration config #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

rlpratt12
Copy link

@rlpratt12 rlpratt12 commented Apr 22, 2025

Closes https://github.com/PickNikRobotics/moveit_pro/issues/11194.

Added external camera calibration procedure example config.

Depends on https://github.com/PickNikRobotics/moveit_pro/pull/12204

… with TF version. Direct detect version WIP.
…ot urdf tfs. Pro detection is working now too, but hardcoded camera topics.
… detection. External detection works well, internal does not.
@rlpratt12 rlpratt12 added this to the 8.0.0 milestone Apr 30, 2025
@rlpratt12 rlpratt12 marked this pull request as ready for review May 1, 2025 01:54
@rlpratt12 rlpratt12 self-assigned this May 1, 2025
Copy link

@dyackzan dyackzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of assets that are copied here that don't need to be or should be pulled out into a common resource package if they really are shared and also needed in this config

  • space_satellite_sim_camera_cal/meshes
  • space_satellite_sim_camera_cal/description/mujoco/kinova
  • space_satellite_sim_camera_cal/description/mujoco/landsat
  • space_satellite_sim_camera_cal/description/mujoco/rafti
  • space_satellite_sim_camera_cal/description/mujoco/robotiq_2f85

Also I'm wondering about the motivation for creating this calibration config in a space environment. Would it be simpler/easier to do this based on the kinova_sim config and just call it something like kinova_calibration_sim?

@dyackzan
Copy link

dyackzan commented May 2, 2025

You can reference the premier_labs_ws for an example of sharing assets between configs, where the premier_assets package houses common assets used in both the premier_fanuc_sim and premier_ur20_sim configs. You could use a workflow like that for common kinova assets, and you can put other ones (like the space/calibration tool assets) in picknik_accessories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants