Fix incorrect plugInfo library path matching on macOS #3657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updatePluginfos.py script previously used a substring match
(f'libs/{libname}' in newname) to find relocated libraries, which
could result in incorrect matches (e.g., 'libusd_arch.dylib' matching
for 'libusd_ar'). Restrict match to full library names by requiring
a trailing dot.
Collaborator
|
Filed as internal issue #USD-11061 (This is an automated message. See here for more information.) |
meshula
pushed a commit
to meshula/USD
that referenced
this pull request
Sep 11, 2025
…library file matches Closes PixarAnimationStudios#3657 (Internal change: 2370834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The
updatePluginfos.pyscript previously used a substring match (f'libs/{libname}' in newname) to find relocated libraries, which could result in incorrect matches (e.g., 'libusd_arch.dylib' matching for 'libusd_ar'). Restrict match to full library names by requiring a trailing dot.Fixes Issue(s)
This patch tightens the condition to only match full library names by appending a dot ('.') to ensure correct basename detection.
Fixes: #3656
Checklist
testing guidelines)
Contributor License Agreement instructions)