NVIDIA: Add computation to deform normals for CPU #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nvmkuruc for vis. |
roggiezhang-nv
force-pushed
the
normals_skinning_cpu
branch
from
d3b84df to
4423da2
Compare
roggiezhang-nv
force-pushed
the
normals_skinning_cpu
branch
from
4423da2 to
502c92b
Compare
Collaborator
|
Filed as internal issue #USD-11073 (This is an automated message. See here for more information.) |
This was referenced Jul 2, 2025
pixar-oss
pushed a commit
that referenced
this pull request
Aug 6, 2025
This means that the normals need to be computed post-skinning (by the render delegate), rather than using the undeformed normals from the rest geometry, and matches the UsdImaging 1.0 behavior and addresses bug #3699. Note that the open PRs (e.g. #3664) to add support for normals in the skinning computation would supersede this. Closes #3700 (Internal change: 2374067)
meshula
pushed a commit
to meshula/USD
that referenced
this pull request
Sep 11, 2025
This means that the normals need to be computed post-skinning (by the render delegate), rather than using the undeformed normals from the rest geometry, and matches the UsdImaging 1.0 behavior and addresses bug PixarAnimationStudios#3699. Note that the open PRs (e.g. PixarAnimationStudios#3664) to add support for normals in the skinning computation would supersede this. Closes PixarAnimationStudios#3700 (Internal change: 2374067)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
USD supresses normals, and instead normals will be computed post skinning as if they were authored. This PR is to support normals deformation for CPU.
This PR is based on #3663.
Link to proposal (if applicable)
Fixes Issue(s)
#3406
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)