This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Introducing logical fromUnixTime func #1504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelewski
force-pushed
the
logical-fromunit-func
branch
from
61214ea to
5326b4d
Compare
…es transformation into account and are used by search functionality
Contributor
Author
|
/run-it |
Contributor
Author
|
/run-it |
Contributor
Author
|
/run-it |
1 similar comment
Contributor
Author
|
/run-it |
pdelewski
force-pushed
the
logical-fromunit-func
branch
from
6048aba to
09ea693
Compare
Contributor
Author
|
/run-it |
pdelewski
requested review from
avelanarius,
jakozaur,
nablaone,
stared and
trzysiek
mieciu
reviewed
Aug 4, 2025
mieciu
reviewed
Aug 4, 2025
mieciu
reviewed
Aug 4, 2025
mieciu
reviewed
Aug 4, 2025
platform/parsers/elastic_query_dsl/pancake_sql_query_generation_test.go
Outdated
Show resolved
Hide resolved
mieciu
reviewed
Aug 4, 2025
platform/parsers/elastic_query_dsl/pancake_sql_query_generation_test.go
Outdated
Show resolved
Hide resolved
mieciu
suggested changes
Aug 4, 2025
Member
mieciu
left a comment
mieciu
left a comment
There was a problem hiding this comment.
minor catches, overall - good job!
Contributor
Author
|
/run-it |
mieciu
reviewed
Aug 5, 2025
| if col, ok := model.ExtractColRef(f.Args[0]); ok && table.IsInt(col.ColumnName) { | ||
| // adds fromUnixTimestamp64Milli | ||
| return model.NewFunction("toTimezone", model.NewFunction("fromUnixTimestamp64Milli", f.Args[0]), f.Args[1]) | ||
| return model.NewFunction("toTimezone", model.NewFunction(model.FromUnixTimeFunction64mili, f.Args[0]), f.Args[1]) |
mieciu
approved these changes
Aug 5, 2025
pdelewski
force-pushed
the
logical-fromunit-func
branch
from
89ca35d to
c50826e
Compare
pdelewski
force-pushed
the
logical-fromunit-func
branch
from
c50826e to
b72bde0
Compare
Contributor
Author
|
/run-it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an abstract logical
FromUnixTimeFunctionandFromUnixTimeFunction64milifunctions to be used at the parsing level, and adds a extend DateTimeFunction transformation that lowers it to a backend-specific implementation.