-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autorace Humble update #61
Conversation
Merge it into the Humble update branch. After final review in the Humble update branch, I plan to create a PR to Main.
…OBOTIS-GIT/turtlebot3_autorace into feature-autorace-humble-update
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
…OBOTIS-GIT/turtlebot3_autorace into feature-autorace-humble-update
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Hyungyu Kim <[email protected]>
Signed-off-by: Pyo <[email protected]>
Signed-off-by: Pyo <[email protected]>
Signed-off-by: Pyo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the TurtleBot3 Autorace project to support the Humble release, reorganizing the package structure while refining detection, calibration, and mission functionalities. Key changes include updating package metadata in setup.py, adding new GitHub Actions workflows for CI and linting, revising documentation in README.md and CONTRIBUTING.md, and adjusting YAML configurations for camera calibration.
Reviewed Changes
File | Description |
---|---|
turtlebot3_autorace/setup.py | Adds package metadata and configuration for the meta package. |
.github/workflows/ros-ci.yml | Introduces CI workflow for building and testing on ROS Humble. |
.github/workflows/ros-lint.yml | Adds a lint workflow using a ROS rolling environment. |
CONTRIBUTING.md | Adds contribution guidelines under the Apache 2 License. |
README.md | Updates project links and branch info with relevant changes. |
turtlebot3_autorace_camera/calibration/extrinsic_calibration/compensation.yaml | Adds YAML configuration for camera image compensation. |
turtlebot3_autorace_camera/calibration/extrinsic_calibration/projection.yaml | Updates YAML calibration parameters for camera image projection. |
Copilot reviewed 119 out of 119 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
turtlebot3_autorace/setup.py:6
- The email 'N/A' for 'Leon Jung' is a placeholder; consider replacing it with a valid email address or handling missing email values explicitly.
('Leon Jung', 'N/A'),
@sunghowoo @yun-goon PING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, the porting of the TurtleBot3 AutoRace Humble version has been completed. Thank you for your hard work! 🚀👏 @chan-1207 @GyuH13 @iamjunyeong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autorace can now be run on Humble! Sounds great!
Description
It supports the Humble version of AutoRace. It is composed of four packages, each responsible for the meta package, camera calibration, detection, and actions(mission).
turtlebot3_autorace
: meta packageturtlebot3_autorace_camera
: A package responsible for camera calibrationturtlebot3_autorace_detect
: A package responsible for detectionturtlebot3_autorace_mission
: A package responsible for the motion of TurtleBot3** Support Function**
Exception
Change