[Comgr] Port isa_name_parsing_test to LIT and add SPIR-V identifier coverage#2710
Open
theSK2005 wants to merge 3 commits into
Open
[Comgr] Port isa_name_parsing_test to LIT and add SPIR-V identifier coverage#2710theSK2005 wants to merge 3 commits into
theSK2005 wants to merge 3 commits into
Conversation
…overage Ported isa_name_parsing_test from CTest to LIT. Adjusted CMakeList.txt files appropriately.
theSK2005
force-pushed
the
skushwah/lit_isa_name_parsing
branch
from
7b56ef5 to
4988e3f
Compare
lamb-j
reviewed
May 28, 2026
lamb-j
reviewed
May 28, 2026
lamb-j
reviewed
May 28, 2026
lamb-j
reviewed
May 28, 2026
lamb-j
reviewed
May 28, 2026
This was referenced May 28, 2026
theSK2005
commented
May 29, 2026
| const char *reason = ""; | ||
|
|
||
| if (argc != 3) { | ||
| fprintf(stderr, "Usage: parse-isa-name <isa-name> <expected-status>\n"); |
Author
There was a problem hiding this comment.
Should I replace this fprintf and exit with a fail?
lamb-j
added a commit
that referenced
this pull request
May 29, 2026
The short-circuit in `amd_comgr_action_info_set_isa_name` checked for `spir64-...` but the canonical HIP SPIR-V triple is `spirv64-...` (LLVM `Triple::spirv64`) — matching `parseTargetIdentifier` (SWDEV-533122) and the strings CLR passes in. Introduced as a typo in 967115f. Dead code on real inputs: nothing in CLR or the LLVM amd subtree passes `spir64-amd-amdhsa-...amdgcnspirv`. Fix aligns the two Comgr call sites with clang and CLR. Discovered while reviewing #2710.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported isa_name_parsing_test from CTest to LIT. Adjusted CMakeList.txt files appropriately.