Skip to content

Parameter Tuning Code Integration: update evaluation and add egfr gold standard #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Mar 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
1872c48
ideas for parameter tuning
ntalluri Oct 28, 2024
7e0a990
update to ml code for centroid, update to eval code to have recall
ntalluri Oct 29, 2024
d5d0461
integrated all the code
ntalluri Nov 1, 2024
20d20bf
new updates to the integration
ntalluri Nov 4, 2024
71aa43e
clean up of comments
ntalluri Nov 4, 2024
691673c
updated test_ml.py to work with new updates
ntalluri Nov 4, 2024
26178f9
in progress of testing
ntalluri Nov 7, 2024
a5b3205
spras/con
ntalluri Nov 14, 2024
0aeda95
update to config.py to deal with ml and eval coupling
ntalluri Nov 15, 2024
46c87fc
added TODO comments on ideas to scale the binary data, still not sure…
ntalluri Nov 15, 2024
5265c53
cleaned up file names and left TODOs
ntalluri Nov 15, 2024
9b7e687
added the eval test cases, made a todo for config test case
ntalluri Nov 15, 2024
23d1070
added algorithms to be used for eval code
ntalluri Nov 15, 2024
0408a20
pre commit test_evaluate.py
ntalluri Nov 15, 2024
f1f58e7
updated evalute.py
ntalluri Nov 15, 2024
3507475
updated all config files
ntalluri Nov 15, 2024
dd0359f
cleane dup spras/evaluation.py
ntalluri Nov 15, 2024
ef15799
updated spacing and added comments to the config files
ntalluri Nov 18, 2024
47dab1a
updated evalution.py code
ntalluri Nov 18, 2024
b3504b5
cleaned up eval tests and added coupling tests to config
ntalluri Nov 18, 2024
dfcd302
change how plot is
ntalluri Dec 5, 2024
97a7d7b
precommit
ntalluri Dec 9, 2024
8eb2ca1
reset to having changed to make it about eval without each of the par…
ntalluri Mar 3, 2025
c2d627b
revert expected pca coordinates/tsv
ntalluri Mar 11, 2025
6445525
Update config/config.yaml
ntalluri Mar 17, 2025
8ebb890
Apply suggestions from code review
ntalluri Mar 17, 2025
577dcec
update to documentation, config file, and egfr gold standard
ntalluri Mar 21, 2025
ed60b4e
update to config.py
ntalluri Mar 21, 2025
0e80d03
parameterized test cases
ntalluri Mar 21, 2025
5669762
clean up input readme
ntalluri Mar 21, 2025
99d00f1
Code linting
agitter Mar 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Snakefile
Original file line number Diff line number Diff line change
Expand Up @@ -384,4 +384,4 @@ rule evaluation:

# Remove the output directory
rule clean:
shell: f'rm -rf {out_dir}'
shell: f'rm -rf {out_dir}'
5 changes: 5 additions & 0 deletions config/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -173,4 +173,9 @@ analysis:
# 'euclidean', 'manhattan', 'cosine'
metric: 'euclidean'
evaluation:
# evaluation per dataset-goldstandard pair
# evaluation will not run unless ml include is set to true
include: true
# adds evaluation per algorithm per dataset-goldstandard pair
# evaluation per algortihm will not run unless ml include and ml aggregate_per_algorithm are set to true
aggregate_per_algorithm: true
Loading
Loading