fix: make omicsintegrator2 work offline #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[I mainly used this issue as an excuse to experiment with a git patch workflow over the forking method that seems to be present in SPRAS] Forces OI2 to work offline by disabling the unused networkx graph as interactive HTML feature (we already have workflows in SPRAS that enable this). The network error was coming from `output_networkx_graph_as_interactive_html` dynamically fetching jQuery to insert it as an inline script. This could have also been fixed by providing a `local` folder with all of the scripts, but putting the several hundred-kilobyte scripts on this repository did not seem worth it for an unused feature.
tristan-f-r
changed the title
ntalluri
reviewed
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[I mainly used this issue as an excuse to experiment with a git patch workflow over the forking method that seems to be present in SPRAS]
Forces OI2 to work offline by disabling the unused networkx graph as interactive HTML feature (we already have workflows in SPRAS that enable this).
The network error was coming from
output_networkx_graph_as_interactive_htmldynamically fetching jQuery to insert it as an inline script. This could have also been fixed by providing alocalfolder with all of the scripts, but putting the several hundred-kilobyte scripts on this repository did not seem worth it for an unused feature.This is tested - this also introduces a (docker-only)
network_disabledparameter for running containers with a detached network.A similar trick can work for #137.
Closes #78.