-
Notifications
You must be signed in to change notification settings - Fork 24
fix: tighten & relax yaml parsing constraints #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
didn't know about that `raise ... from None`! so much to learn
Could you add test cases in test/config.py for this updated change? |
Thanks! I forgot we had a dedicated test file for configs. |
I was testing the different list options that could be used for the parameters using the config options below.
I keep getting this error:
The parsing stops after reading the omicsintegrator2 params, but I don't see any progress for reading MEO. |
Interesting - I'll add more tests to cover all of these cases. |
I do believe that that error is from the same origin as this "temporary" patch Lines 246 to 247 in 73184ed
|
It seems we never tested for |
Adding more tests for some more code coverage. |
Note: test egfr config |
This checks for object prefixes before using
eval
. Instead, the parsing goes as:np.
to always be allowed.)This does make config parsing perhaps more rigid, but this has the side bonus of allowing singleton values.
(I chose not to prefer
eval
here, as I do not want to see how the pythoneval
system and the already broad YAML format interact with each other. I still do an extraiterable
check so the "can't index X by string" error appears without a recognizable stacktrace.)This addresses two out of the three wants from #33.