-
Notifications
You must be signed in to change notification settings - Fork 24
fix: let raw_pathway_df handle present headers but no data #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I was running a full pilot run of all the data of the pilot synthetic networks for my thesis. |
(currently trying to generate an empty DOMINO test file) |
@ntalluri good catch! DOMINO also would have had a similar error. |
test/parse-outputs/input/empty/omicsintegrator2-empty-raw-pathway.txt
Outdated
Show resolved
Hide resolved
test/parse-outputs/input/empty/omicsintegrator2-empty-raw-pathway-2.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
If more OI2 test cases appear, I will add them. I can not find any more, and the fact that we don't have any issues reporting other OI2 test cases means that most likely these edge cases are caught. [I can also add some more if anyone has datasets that would bring about these types of errors, but I do not have these.] |
This issue has some of the empty files #133 (comment) One more test case is
|
Have you tried running a large test sweep on egfr? |
[I forgot to put in my commit for the protein1-protein2 dataset] |
I have - the only empty header file I've gotten back was |
I think that is the only one i have run into as well |
(@ntalluri what exactly did you do for #233? I think this addresses a separate issue, but I'm not entirely sure.)Closes #233.