Skip to content

fix: let raw_pathway_df handle present headers but no data #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented May 28, 2025

(@ntalluri what exactly did you do for #233? I think this addresses a separate issue, but I'm not entirely sure.)

Closes #233.

@ntalluri
Copy link
Collaborator

I was running a full pilot run of all the data of the pilot synthetic networks for my thesis.

@tristan-f-r tristan-f-r changed the title test(MEO): empty files fix: let raw_pathway_df handle present headers but no data. May 28, 2025
@tristan-f-r tristan-f-r changed the title fix: let raw_pathway_df handle present headers but no data. fix: let raw_pathway_df handle present headers but no data May 28, 2025
@tristan-f-r tristan-f-r added the infrastructure misc. changes made to SPRAS itself label May 29, 2025
@tristan-f-r
Copy link
Collaborator Author

(currently trying to generate an empty DOMINO test file)

@tristan-f-r
Copy link
Collaborator Author

@ntalluri good catch! DOMINO also would have had a similar error.

Co-authored-by: Neha Talluri <78840540+ntalluri@users.noreply.github.com>
@tristan-f-r
Copy link
Collaborator Author

If more OI2 test cases appear, I will add them. I can not find any more, and the fact that we don't have any issues reporting other OI2 test cases means that most likely these edge cases are caught.

[I can also add some more if anyone has datasets that would bring about these types of errors, but I do not have these.]

@ntalluri
Copy link
Collaborator

ntalluri commented Jun 12, 2025

This issue has some of the empty files #133 (comment)

One more test case is

protien1 protien2

@ntalluri ntalluri closed this Jun 12, 2025
@ntalluri ntalluri reopened this Jun 12, 2025
@ntalluri
Copy link
Collaborator

If more OI2 test cases appear, I will add them. I can not find any more, and the fact that we don't have any issues reporting other OI2 test cases means that most likely these edge cases are caught.

[I can also add some more if anyone has datasets that would bring about these types of errors, but I do not have these.]

Have you tried running a large test sweep on egfr?

@tristan-f-r
Copy link
Collaborator Author

[I forgot to put in my commit for the protein1-protein2 dataset]

@tristan-f-r
Copy link
Collaborator Author

I have - the only empty header file I've gotten back was protein1 protein2. Perhaps I'm running it wrong?

@ntalluri
Copy link
Collaborator

I think that is the only one i have run into as well

@ntalluri ntalluri added the needed for benchmarking Priority PRs needed for the benchmarking paper label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure misc. changes made to SPRAS itself needed for benchmarking Priority PRs needed for the benchmarking paper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MEO Empty File Parse Output Error
2 participants