style: yamlfmt #239
Open
style: yamlfmt #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan-f-r
commented
May 28, 2025
| @@ -24,3 +24,7 @@ repos: | |||
| rev: 'v0.0.269' | |||
| hooks: | |||
| - id: ruff | |||
| - repo: https://github.com/google/yamlfmt | |||
There was a problem hiding this comment.
Note that the actual lines of code changed are here - this uses a pinned version of the yamlfmt pre-commit hook provided by Google.
tristan-f-r
added
infrastructure
agitter
reviewed
Jun 6, 2025
tristan-f-r
removed
the
easy
|
Since reviewing all of these YAML files is quite a tedious task, I've removed |
|
Restricted |
tristan-f-r
added
the
easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48. this uses the yamlfmt default config, which uses 2 spaces instead of four - a convention that seems to be recommended.
[If any style opinion that deviates from yamlfmt's default is preferred I will immediately add it. I do not want bikeshedding.]