-
Notifications
You must be signed in to change notification settings - Fork 24
feat: ROBUST #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tristan-f-r
wants to merge
12
commits into
Reed-CompBio:main
Choose a base branch
from
tristan-f-r:robust
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: ROBUST #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didn't notice that unduplicating edges did this
tristan-f-r
commented
May 30, 2025
# to nodes if they are overstudied. By taking the inverse of these, this deincentivizes ROBUST from exploring nodes | ||
# with low prizes, which approximates the idea of incentivizing exploring nodes with positive prizes. | ||
# See more at "Online bias-aware disease module mining with ROBUST-Web," as the original ROBUST paper | ||
# did not incorporate study bias scores. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strangest part of this PR is this - to allow for users to incorporate prizes, this transforms them into ROBUST's penalizing study bias scores.
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109. ROBUST has only one quirk and was a straightforward integration.
ROBUST does come with a way to automatically derive scores from preset databases, but we should probably let SPRAS handle that instead. (@ntalluri namely, I think leaving out
namespace
and the non-filestudy-bias-score
params is okay, but I would love to know if this is okay to do.)