-
Notifications
You must be signed in to change notification settings - Fork 24
feat: BTB #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: BTB #250
Conversation
finished testing the LocalNeighborhood. Moving to make the dockerfile
BTB should be ready to be implemented into SPRAS.
with motivating context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things to check; a few larger issues raised but we'll make new PRs/Issues for them.
if not Path(sources).exists() or not Path(targets).exists() or not Path(edges).exists(): | ||
raise ValueError('Missing input file') | ||
|
||
# Testing for btb index errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not be relevant anymore (if it is, it should be in prepare_inputs()
). Try commenting out and checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other PRs, there's another similar check in the run()
function. This was because the error's raised in the docker image but pytest can't see it. Might be a flaw of the way our run tests are organized.
|
||
edges.to_csv(filename_map["edges"], sep="\t", index=False, | ||
columns=["Interactor1", "Interactor2", "Weight"], | ||
header=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be where the "btb index check" code might go.
supersedes #150, #168, and #204 - link to algorithm