Skip to content

feat: BTB #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

feat: BTB #250

wants to merge 66 commits into from

Conversation

tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Jun 3, 2025

supersedes #150, #168, and #204 - link to algorithm

@tristan-f-r tristan-f-r added the algorithm Pathway reconstruction algorithm to add to SPRAS label Jun 3, 2025
Copy link
Contributor

@annaritz annaritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to check; a few larger issues raised but we'll make new PRs/Issues for them.

if not Path(sources).exists() or not Path(targets).exists() or not Path(edges).exists():
raise ValueError('Missing input file')

# Testing for btb index errors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be relevant anymore (if it is, it should be in prepare_inputs()). Try commenting out and checking.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other PRs, there's another similar check in the run() function. This was because the error's raised in the docker image but pytest can't see it. Might be a flaw of the way our run tests are organized.


edges.to_csv(filename_map["edges"], sep="\t", index=False,
columns=["Interactor1", "Interactor2", "Weight"],
header=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be where the "btb index check" code might go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Pathway reconstruction algorithm to add to SPRAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants