Skip to content

fix: check if edge weights are between 0 and 1 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tristan-f-r
Copy link
Collaborator

Closes #237.

@tristan-f-r tristan-f-r added infrastructure misc. changes made to SPRAS itself easy PRs which take at most a minute to review with little thinking. labels Jun 4, 2025
@tristan-f-r
Copy link
Collaborator Author

Actually, I do want to print out what the value is (don't want anyone to have to try to write a script or perhaps even a regex to try to find what the outlier value is)

@tristan-f-r tristan-f-r marked this pull request as draft June 4, 2025 00:02
@tristan-f-r tristan-f-r marked this pull request as ready for review June 4, 2025 15:45
@tristan-f-r
Copy link
Collaborator Author

[Do we have an established way of testing dataset parsing? A quick look says there isn't any, but it could be useful to add for e.g. #254]

@ntalluri
Copy link
Collaborator

This would be a good chance to add in a test for dataset parsing.

@tristan-f-r
Copy link
Collaborator Author

tristan-f-r commented Jun 11, 2025

That sounds good - @ntalluri should I combine this PR and #254 and add some encapsulating dataset test file for the two in the resulting PR?

@ntalluri
Copy link
Collaborator

I would keep them separate for now as they target different things. We can plan to merge this pr before 254. I would add the test case here first then once merged, pull it into 254.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy PRs which take at most a minute to review with little thinking. infrastructure misc. changes made to SPRAS itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Rank/Weight Values Between 0 and 1 in Networks
2 participants