Skip to content

fix: never parse index_col from node data #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tristan-f-r wants to merge 14 commits into
base: main
Choose a base branch
from
Open

fix: never parse index_col from node data #379

tristan-f-r wants to merge 14 commits into from

Conversation

@tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Aug 21, 2025 •
edited
Loading

If we allow index_col, node parsing may eagerly try to make NODEID the index column, as seen with the mysterious behavior from #372 (comment).

The actual change: 74e3080#diff-653dc3d26b49426091644530fd67546a515635c07bbcb0b6796c3d9d2f4ad0d0R124

@tristan-f-r tristan-f-r mentioned this pull request Aug 21, 2025
Open
@read-the-docs-community
Copy link

read-the-docs-community bot commented Aug 21, 2025

Documentation build overview

📚 spras | 🛠️ Build #29283572 | 📁 Comparing 74e3080 against latest (647f4a1)


🔍 Preview build

Show files changed (3 files in total): 📝 3 modified | ➕ 0 added | ➖ 0 deleted
File Status
genindex.html 📝 modified
fordevs/modules.html 📝 modified
fordevs/spras.html 📝 modified

@tristan-f-r tristan-f-r added bug Something isn't working blocked-by-other-pr easy PRs which take at most a minute to review with little thinking. labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

blocked-by-other-pr bug Something isn't working easy PRs which take at most a minute to review with little thinking.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tristan-f-r