Skip to content

Conversation

@tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Sep 6, 2025

The result of

mkdir test/algorithms
git mv test/AllPairs/ test/BowTieBuilder/ test/DOMINO/ test/LocalNeighborhood/ test/MEO test/MinCostFlow/ test/OmicsIntegrator1 test/OmicsIntegrator2 test/PathLinker/ test/ResponseNet/ test/RWR/ test/ST_RWR/ test/algorithms/

with manual changes for file paths.

This is a convenient change for #364, as it helps the Windows CI ignore the unrunnable docker containers (see #23). We may also want to do this for the actual spras source code, but that's more refactor-heavy than this.

@tristan-f-r tristan-f-r added refactor Changes that don't actually improve anything except for code quality. infrastructure misc. changes made to SPRAS itself labels Sep 6, 2025
@tristan-f-r tristan-f-r mentioned this pull request Sep 6, 2025
3 tasks
@tristan-f-r tristan-f-r added the easy PRs which take at most a minute to review with little thinking. label Sep 19, 2025
@tristan-f-r tristan-f-r marked this pull request as draft September 25, 2025 05:19
@tristan-f-r tristan-f-r added the awaiting-author Author of the PR needs to fix something from a review / etc. label Sep 25, 2025
@agitter
Copy link
Collaborator

agitter commented Oct 3, 2025

How did this help #364? I wasn't clear on why we ignore so many tests on Windows, which we could discuss there instead of here.

@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Oct 11, 2025
@read-the-docs-community
Copy link

read-the-docs-community bot commented Oct 14, 2025

Documentation build overview

📚 spras | 🛠️ Build #30359964 | 📁 Comparing 0e5aed9 against latest (24fe346)


🔍 Preview build

No files changed.

@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Oct 14, 2025
@tristan-f-r tristan-f-r marked this pull request as ready for review October 14, 2025 06:02
@tristan-f-r tristan-f-r removed the awaiting-author Author of the PR needs to fix something from a review / etc. label Oct 14, 2025
@tristan-f-r
Copy link
Collaborator Author

We ignore all of the algorithm tests on #364: this PR means we don't need to manually list every single algorithm one-by-one.

@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Oct 17, 2025
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Oct 17, 2025
@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Oct 24, 2025
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Oct 25, 2025
@tristan-f-r tristan-f-r added P-medium medium prirotity; this is needed for some external service or another PR and removed P-medium medium prirotity; this is needed for some external service or another PR labels Oct 29, 2025
@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Nov 7, 2025
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy PRs which take at most a minute to review with little thinking. infrastructure misc. changes made to SPRAS itself refactor Changes that don't actually improve anything except for code quality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants