-
Notifications
You must be signed in to change notification settings - Fork 25
test: mv algorithm tests to subfolder #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tristan-f-r
wants to merge
12
commits into
Reed-CompBio:main
Choose a base branch
from
tristan-f-r:test-alg-move
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
How did this help #364? I wasn't clear on why we ignore so many tests on Windows, which we could discuss there instead of here. |
3e5acea to
fcc8d2d
Compare
fcc8d2d to
bcb219b
Compare
Collaborator
Author
|
We ignore all of the algorithm tests on #364: this PR means we don't need to manually list every single algorithm one-by-one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
easy
PRs which take at most a minute to review with little thinking.
infrastructure
misc. changes made to SPRAS itself
refactor
Changes that don't actually improve anything except for code quality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
with manual changes for file paths.
This is a convenient change for #364, as it helps the Windows CI ignore the unrunnable docker containers (see #23). We may also want to do this for the actual
sprassource code, but that's more refactor-heavy than this.