Skip to content

[workspace] Upgrade vtk_internal to latest commit #23064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

Aiden2244
Copy link
Contributor

@Aiden2244 Aiden2244 commented Jun 3, 2025

Towards #23055

vtk_internal broke the new_release script. VTK typically requires manual intervention for the monthly upgrade process. See previous month's VTK upgrade here: #23038


This change is Reviewable

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: do not review)
FYI @jwnimmer-tri who should do the necessary mods?

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", missing label for release notes (waiting on @Aiden2244)

@jwnimmer-tri
Copy link
Collaborator

For VTK problems, the standing request is to have Kitware try fixing it first, and only kick it to TRI if they can't figure it out.

@Aiden2244 Aiden2244 mentioned this pull request Jun 4, 2025
10 tasks
@jwnimmer-tri jwnimmer-tri changed the title BROKEN [workspace] Upgrade vtk_internal to latest commit [workspace] Upgrade vtk_internal to latest commit Jun 5, 2025
@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) and removed status: do not merge status: do not review labels Jun 5, 2025
@jwnimmer-tri
Copy link
Collaborator

+@rpoyner-tri for both reviews, please.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @Aiden2244)

@rpoyner-tri rpoyner-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Jun 6, 2025
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: squashing now)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)

@rpoyner-tri rpoyner-tri merged commit b3d36b2 into RobotLocomotion:master Jun 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants