-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[pydrake] Bind CollisionFilterScope #23091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pydrake] Bind CollisionFilterScope #23091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@SeanCurtis-TRI for (single?) review please.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform), needs at least two assigned reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(status: single reviewer ok)
Reviewable status:
complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm...I think the release notes should be fix? Otherwise we won't pick up new bindings in the release note? Or is this because it is deformable related?
Reviewable status:
complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-(release notes: none) +(release notes: fix)
Agreed. I'm too used to adding the "none" tag and I wasn't thinking.
Reviewable status:
complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)
This change is