[pydrake] Align with nanobind factory constructor API (part 3)#24751
[pydrake] Align with nanobind factory constructor API (part 3)#24751jwnimmer-tri wants to merge 1 commit into
Conversation
|
@drake-jenkins-bot linux-noble-clang-bazel-experimental-undefined-behavior-sanitizer please |
jwnimmer-tri
left a comment
There was a problem hiding this comment.
+a:@rpoyner-tri for co-feature review, please. I took this commit of yours from the branch and prepped it for master (reformatting).
@jwnimmer-tri reviewed 6 files and all commit messages, and made 2 comments.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers (waiting on jwnimmer-tri and rpoyner-tri).
a discussion (no related file):
Working
Needs platform reviewer assigned.
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri reviewed 6 files and all commit messages, and made 2 comments.
Reviewable status: 2 unresolved discussions, needs at least two assigned reviewers (waiting on jwnimmer-tri).
systems/analysis/test/simulator_test.cc line 818 at r1 (raw file):
} // Tests the internal use (for Python) in-place construction factory method
nit I now find this sentence hard to parse; lots of modifiers are piled up.
Two lame suggestions; perhaps you'll think of a better one.
Tests the (internal use for Python) in-place construction factory method
Tests the internal-use (for Python) in-place construction factory method
rpoyner-tri
left a comment
There was a problem hiding this comment.
@rpoyner-tri made 1 comment.
Reviewable status: 2 unresolved discussions, needs at least two assigned reviewers (waiting on jwnimmer-tri).
systems/analysis/test/simulator_test.cc line 818 at r1 (raw file):
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
nit I now find this sentence hard to parse; lots of modifiers are piled up.
Two lame suggestions; perhaps you'll think of a better one.
Tests the (internal use for Python) in-place construction factory methodTests the internal-use (for Python) in-place construction factory method
Or perhaps even better:
Tests the in-place construction factory method
b36bc26 to
2cca9f2
Compare
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 2 files and all commit messages, made 2 comments, and resolved 2 discussions.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee ggould-tri(platform) (waiting on ggould-tri and rpoyner-tri).
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
Needs platform reviewer assigned.
+a:@ggould-tri for platform review per schedule, please.
a discussion (no related file):
@rpoyner-tri I found one more patch to cherry-pick. PTAL.
Towards #21572.
Same as #24600 and #24742 -- we weren't sure at the time if these were also the right fixes, but it seems like they are.
This change is