feat: various enhancements#44
Merged
Merged
Conversation
* feat: agentic trace * feat: pixi demo-trace task * refactor: demo trace * chore: increase inference server setup timeout * fix: demo trace log handling * docs: agentic trace
zakmat
approved these changes
Jul 6, 2026
zakmat
left a comment
zakmat
left a comment
Member
There was a problem hiding this comment.
Overall looks good, I want to verity TASK param escaping in demo_trace.sh still
| set -euo pipefail | ||
|
|
||
| DEMO_ROOT="${DEMO_ROOT:-$(pwd)}" | ||
| TASK="${TASK:-Prepare shipping of the following items: one CPU, }" |
Member
Author
There was a problem hiding this comment.
It's 1 to 1 with the HMI. Decided to reuse the same wording for completeness.
| resolve_trace_dir | ||
| log "Sending task: $TASK" | ||
| before_size=$(filesize "$LOG") | ||
| ros2 topic pub --once /user_tasks std_msgs/msg/String "{data: '${TASK//\'/\'\\\'\'}'}" >/dev/null |
Member
There was a problem hiding this comment.
Do we have a test case for apostrothe in the TASK? e.g TASK="Don't touch rack J01" produces {data: 'Don'''t ...'}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation update
Agentic trace local & docker