Allow nil to be used as a default_currency#1095
Conversation
sirwolfgang
force-pushed
the
main
branch
2 times, most recently
from
3d37755 to
a6389d0
Compare
sunny
left a comment
sunny
left a comment
There was a problem hiding this comment.
Can you add an entry to the CHANGELOG as well? 🙏🏻
|
@sunny Yeah my bad, updated. |
|
We would love to see this included as well. A default currency is a hard no for our use case. Is there any chance to get this merged anytime soon? |
|
Any chance this can get merged? |
|
@sirwolfgang I am happy to unblock this and the corresponding money-rails PR if you resolve the conflicts 💪🏻 |
Co-authored-by: Sunny Ripert <sunny@sunfox.org>
|
@yukideluxe Yay, rebased! |
yukideluxe
left a comment
yukideluxe
left a comment
There was a problem hiding this comment.
Thanks! Our intention is to release the long-anticipated version 7 very soon, but I think it makes a lot of sense to also remove all the deprecated methods and warnings that were added in preparation for the "next major release." Unless someone beats me to it – 😉😉😉 – we’ll need a few more days 🙏🏻
| # Money.new(100, "EUR") #=> #<Money @fractional=100 @currency="EUR"> | ||
| # | ||
| def initialize( obj, currency = Money.default_currency, options = {}) | ||
| def initialize(obj, currency = Money.default_currency, options = {}) |
5 participants
This is a part of fixing the RubyMoney/money-rails#697