Skip to content
Merged
147 changes: 84 additions & 63 deletions e2e/scripts/pageHelpers.js

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:R1l4lb9rlbpH1:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:rh:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\:"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
"#popover-trigger-\\:rh\\:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct? No multisite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. The generated app has site and locale in config/default.js both set to none and no siteAliases defined. That's just a monorepo thing. So when the previous PR updated snapshots, it probably did it against the buggy generator which was ignoring generator templates and falling back to use the monorepo defaults.

Screenshot 2025-07-14 at 5 52 38 PM

"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:R1l4lb9rlbpH1:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:rh:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\:"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
"#popover-trigger-\\:rh\\:"
]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:R1l4lb9rlbpH1:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:rh:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\:"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
"#popover-trigger-\\:rh\\:"
]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:R1l4lb9rlbpH1:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:rh:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\:"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
"#popover-trigger-\\:rh\\:"
]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:R1l4lb9rlbpH1:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:rf:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\:"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
"#popover-trigger-\\:rf\\:"
]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:R1l4lb9rlbpH1:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:rf:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\:"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
"#popover-trigger-\\:rf\\:"
]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,18 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/global/en-GB/cart\">",
"html": "<a class=\"...\" aria-label=\"Back to cart, number of items: 2\" href=\"/cart\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".css-1k2aozt"
]
},
{
"html": "<div class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
".chakra-portal:nth-child(10)"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got rid of one and added new one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a false update. Apparently when I last updated the snapshot there were still some other things broken.
Now all other tests pass and I updated the snapshot again and exactly this change reverted back.
So we should be good to go. Thanks for catching this.

}
]
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:r5k:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:r5m:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:r5k\\:"
"#popover-trigger-\\:r5m\\:"
]
}
]
Expand All @@ -23,26 +23,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/color-contrast?application=playwright",
"nodes": [
{
"html": "<span class=\"...\">Free</span>",
"failureSummary": "Fix any of the following:\n Element has insufficient color contrast of 3.06 (foreground color: #3ba755, background color: #ffffff, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1",
"html": "<a class=\"...\" href=\"/\">Continue Shopping</a>",
"failureSummary": "Fix any of the following:\n Element has insufficient color contrast of 4.24 (foreground color: #0176d3, background color: #f5f5f5, font size: 12.0pt (16px), font weight: normal). Expected contrast ratio of 4.5:1",
"target": [
".css-xh9uxa"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:r5k\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
".css-a4jxtg"
]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:R1l4lb9rlbpH1:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:rf:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\:"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
"#popover-trigger-\\:rf\\:"
]
}
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,10 @@
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/aria-allowed-attr?application=playwright",
"nodes": [
{
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:R1l4lb9rlbpH1:\">",
"html": "<form id=\"...\" aria-haspopup=\"dialog\" aria-expanded=\"false\" aria-controls=\"popover-content-:rf:\">",
"failureSummary": "Fix all of the following:\n ARIA attribute is not allowed: aria-expanded=\"false\"",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\:"
]
}
]
},
{
"id": "region",
"impact": "moderate",
"description": "Ensure all page content is contained by landmarks",
"help": "All page content should be contained by landmarks",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.10/region?application=playwright",
"nodes": [
{
"html": "<input autocomplete=\"off\" type=\"search\" aria-label=\"Search for products...\" placeholder=\"Search for products...\" id=\"...\" class=\"...\">",
"failureSummary": "Fix any of the following:\n Some page content is not contained by landmarks",
"target": [
"#popover-trigger-\\:R1l4lb9rlbpH1\\: > .css-1igwmid.chakra-stack > .chakra-input__group.css-1y0e7gb > .css-va76oz"
"#popover-trigger-\\:rf\\:"
]
}
]
Expand Down
Loading
Loading