fix: P0 bundle — Wayland, menus, content box, spread order, deskew/oblique (reopens #133) - #152
Conversation
|
Friendly reminder for @zvezdochiot: when you can, please re-test deskew vs oblique on this rebased branch. Steps:
We are holding merge on this bundle until we have that feedback (same as former #133). Thanks again for the earlier report. |
… deskew/oblique - ScanTailor-Advanced#97: Default to QT_QPA_PLATFORM=xcb on Wayland (Qt5) unless SCANTAILOR_NO_XCB_FALLBACK; README. - ScanTailor-Advanced#75: Use QMenu with thumbnail view parent for page context menus. - ScanTailor-Advanced#90: Translate manual content rect with page rect center when page box updates. - ScanTailor-Advanced#62: ProjectPages::setLayoutDirection + Tools action to reverse two-page spread order; OutputFileNameGenerator setter. - ScanTailor-Advanced#117: Separate oblique Auto/Manual (Params + oblique-mode XML), Apply To checkboxes, merge per target page; CacheDrivenTask incomplete thumb when oblique auto.
96de40b to
e7446f0
Compare
Add unit tests for issue ScanTailor-Advanced#117 semantics: deskew-only and oblique-only Apply To… must preserve the other parameter domain; verify oblique-mode attribute round-trips in project XML.
Local re-test: deskew vs oblique (#117)Maintainer re-test on Automated verification (this environment)
New tests added in this pushThree additional cases in
These match Code paths reviewed (static)
GUI smoke test (still recommended before merge)Headless CI cannot exercise Step 3 UI end-to-end. Quick manual check on a real project:
If @zvezdochiot can still confirm on his workflow, great — otherwise maintainer sign-off above + tests is the fallback agreed when the re-test ping had no reply. Proposal: merge when CI is green on |
|
Status: holding — no further changes planned on this branch until we have feedback. Maintainer-side automated re-test for deskew/oblique is documented above ( @vigri — when you have time, could you review this P0 bundle for merge readiness? In particular:
If the approach looks good, we can merge and tag v1.2.1. If something should wait or be split, say so before we touch the branch again. @zvezdochiot — optional but still welcome: GUI smoke test on Step 3 Deskew (checklist in the re-test comment above). No blocker if you are busy; maintainer unit tests cover the #117 merge semantics. We will not push more commits here until there is a clear go/no-go from maintainers. |
Summary
Restores the P0 integration branch from closed PR #133 (branch was deleted accidentally on 2026-05-24, which auto-closed the PR).
Rebased on current
master(includes recent merges through trim #129, inline DPI #93, rename commits on maintainer fork).Issues addressed
QT_QPA_PLATFORM=xcbwhen unset (SCANTAILOR_NO_XCB_FALLBACK=1to opt out)QMenuparent on thumbnail viewNote on #133
Original PR #133 was closed without merge when
fix/p0-plan-issueswas deleted during branch cleanup. This PR continues that work on a restored branch.Test plan
xcbfallback)Not merging until deskew/oblique re-test feedback (same policy as #133).
Related: #133 (supersedes), #97, #75, #90, #62, #117