Skip to content

feat(app): pause automatic thumbnail reordering (#86) - #134

Merged
pablogventura merged 2 commits into
ScanTailor-Advanced:masterfrom
pablogventura:fix/issue-86-pause-sorting-pages
May 24, 2026
Merged

feat(app): pause automatic thumbnail reordering (#86)#134
pablogventura merged 2 commits into
ScanTailor-Advanced:masterfrom
pablogventura:fix/issue-86-pause-sorting-pages

Conversation

@pablogventura

Copy link
Copy Markdown

Fixes #86.

Adds pauseSortingBtn next to the sort direction control. When checked, MainWindow::currentPageOrderProvider() returns nullptr, so ThumbnailSequence::orderItems() does not re-sort thumbnails on invalidateAllThumbnails() while editing.

@pablogventura

Copy link
Copy Markdown
Author

Rebased on current master. CI should be green again.

Please review when you can — not merging yet. Community testers: enable pause on thumbnail reordering, add/remove pages, confirm order stays stable until you resume sorting.

Manual test: Tools → pause automatic thumbnail reordering (or equivalent control in this branch); drag thumbnails; add images; verify order behavior matches #86.

@pablogventura

Copy link
Copy Markdown
Author

Rebased scope on current master: removed two-page spread order UI/handler that belongs in #133 (#62), so this PR is only pause automatic thumbnail reordering (#86).

Local build passes. Please review — not merging yet.

Manual test (#86): enable pause on thumbnail sorting, change sort order / add pages, confirm order stays fixed until pause is released.

Add a toolbar toggle that skips the page order provider while enabled so
thumbnail refreshes keep a stable order during editing.
Remove two-page spread order menu action and handler that belong
in the P0 bundle (ScanTailor-Advanced#133 / ScanTailor-Advanced#62). Fixes CI build after rebase on master.
@pablogventura
pablogventura force-pushed the fix/issue-86-pause-sorting-pages branch from 0dc081c to 2c58526 Compare May 24, 2026 02:10
@pablogventura
pablogventura merged commit fe18144 into ScanTailor-Advanced:master May 24, 2026
3 checks passed
@pablogventura
pablogventura deleted the fix/issue-86-pause-sorting-pages branch May 24, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] "Pause sorting pages" button.

1 participant