-
Notifications
You must be signed in to change notification settings - Fork 67
Network logging improvements #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Network logging improvements #406
Conversation
…lude player name, only login and host)
…change logs in LANAPI::update to print proper IP addresses.
…own packet is received and when a packet cannot be sent.
Could we split this perhaps in 2 Pull Requests? One for the fix and another for the logging? |
Hm, okay I'll do that. I was hoping this would be okay since the changes are pretty trivial. |
Yes size of this change is totally fine, but they do different things. Aka the logging is not needed if someone just wants the text fix. |
Alright, I just removed the tooltip and LAN Serial change out of this PR and updated title and description |
Looks good to me. Will this need a yaml documentation? Perhaps not because it is not user facing. Not hitting the Approve button yet because we still hold off merging code changes. |
Nothing user facing here, so I don't think mention of this in the changelog is neccessary |
In addition, it is worth checking before merging whether the feature can also be implemented for Generals, thus maintaining consistency. |
Some improvements for developers involving network logging:
I also simplified some printing of IP addresses with a new macro PRINT_IP_HELPER. I realize we don't want big refactorings yet, but after expansion this macro should result in the exact same code as before, and it simplifies network debugging in the future. And when we clean up the string handling in the future, we can search for this macro and replace it with a functioncall.