[GEN][ZH] Fix crash on russian replay load when DEBUG_CRASHING is enabled #824
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AsciiString::format is called with format %ls it is supposed to convert Unicode to Ascii. When that conversion fails AsciiString::format throws an exception which results in a serious error.
Long term we should fix this by using UTF-8 everywhere, but for now using AsciiString::translate fixes the problem.
Note that this crash only occurs in debug build and is therefore no problem for retail version. Also the display of the version in the replay menu works fine, just this debug code for an assertion is crashing.
Here is a replay to test:
00-00-01_3v3_DESKTOPT_DESKTOPS_DESKTOPG_MediAI_MediAI_MediAI.zip