[GEN] Backport feature to select all aircraft with hotkey #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roossienb
commented
May 9, 2025
roossienb
commented
May 9, 2025
roossienb
pushed a commit
to roossienb/GeneralsGameCode
that referenced
this pull request
May 9, 2025
roossienb
force-pushed
the
backport-select-all-aircraft
branch
from
569de23 to
93b9cbb
Compare
roossienb
force-pushed
the
backport-select-all-aircraft
branch
from
93b9cbb to
fd0f97d
Compare
roossienb
added
Enhancement
1 task
xezon
reviewed
May 10, 2025
| @@ -2739,7 +2739,51 @@ GameMessageDisposition CommandTranslator::translateGameMessage(const GameMessage | |||
|
|
|||
| //----------------------------------------------------------------------------------------- | |||
| case GameMessage::MSG_META_SELECT_ALL: | |||
| { | |||
| case GameMessage::MSG_META_SELECT_ALL_AIRCRAFT: | |||
There was a problem hiding this comment.
This select all aircraft logic or even select all will cause mismatch in multiplayer right?
If it does, then we need to be able to disable this for Generals with compiler switch.
So:
#if RTS_GENERALS && VC6_BUILD
// the Generals retail behaviour ...
#else
// the Zero Hour behaviour here ...
#endifThis code then also needs to be in Zero Hour, so they become identical before we move them.
There was a problem hiding this comment.
I just realized this is not easy to test because generals has exeCRC in place. We need to spoof that first.
There was a problem hiding this comment.
Yes we need to fake that in both Generals and Zero Hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the feature to select all aircraft with hotkey (default: 'W').
Backport has been performed with WinMerge
The feature is bound to a hotkey that must be defined in
Data/<language>/CommandMap.ini, found in the<language>.BIGfile.To set the hotkey without changing the BIG file, download CommandMap.zip and unzip it into the folder:
<gamedirectory>/Data/<language>/(this version of the command map also contains the earlier backported fast-forward hotkey 'F')