Refactor Players 2/12: Add generic Modern player layout templates#1285
Open
dgruss wants to merge 1 commit into
Open
Refactor Players 2/12: Add generic Modern player layout templates#1285dgruss wants to merge 1 commit into
dgruss wants to merge 1 commit into
Conversation
dgruss
changed the title
dgruss
changed the title
dgruss
force-pushed
the
refactorplayers-12-02-modern-player-templates
branch
from
ba897b1 to
3476b10
Compare
dgruss
force-pushed
the
refactorplayers-12-02-modern-player-templates
branch
from
3476b10 to
555de2c
Compare
Contributor
Author
|
with the merge of #1284 this is now a simple PR as well, just adding new theme elements that are not used yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #1186
Files changed in this PR:
This adds reusable Modern theme templates for player-dependent sing and score elements. These templates are not the main behavior change yet; they prepare the theme file so later PRs can instantiate player blocks from one template instead of many fixed sections.
There is no user-facing / visual change anywhere from this PR - it is only preparing the theme.
(The complete chain fixes #634. Fixes #545. Fixes #732. Fixes #712.)